From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66398C00454 for ; Wed, 11 Dec 2019 15:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FEDE2464B for ; Wed, 11 Dec 2019 15:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576076858; bh=aPdqcuoYB/AxfN1Ijbok5sCn7AQwGNsV+TPJFrNmQa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pweOWjJMSbHkLTTst9hEABNWV1sS6A+ToC0XerZuikb4tE6e30cUCwprmP6qpEpeE /98qeiA4tXzZ27wzFvGR+B2mj6svVFvUKXowJS+BdmcqQ7esLakC5x+fU/rNlsmAXt ia+dGxdm+dEcuSiSpEtYdF2WnM+oLbij/RXJPr9k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730055AbfLKPHh (ORCPT ); Wed, 11 Dec 2019 10:07:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:54778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730010AbfLKPHg (ORCPT ); Wed, 11 Dec 2019 10:07:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08F69222C4; Wed, 11 Dec 2019 15:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576076855; bh=aPdqcuoYB/AxfN1Ijbok5sCn7AQwGNsV+TPJFrNmQa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NU99usv2kkyYI/OCZIcze7zoxJEkK154ShCAJogrNcBeT7bXw2aQfbnhcqDsO7lx1 kv7N7bzh2u1FN7K8fHl2HphGa74Z++fjVJpJtDTH6oGzvGQ3+cCDqsJEL2ZGiTKiL2 RSPKcBA7YM6rtTQ50Aa5hCoS41O//e7BTRw3EkH0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko Subject: [PATCH 5.4 17/92] serial: 8250_dw: Avoid double error messaging when IRQ absent Date: Wed, 11 Dec 2019 16:05:08 +0100 Message-Id: <20191211150226.742908160@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150221.977775294@linuxfoundation.org> References: <20191211150221.977775294@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko commit 05faa64e73924556ba281911db24643e438fe7ba upstream. Since the commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") Signed-off-by: Andy Shevchenko Cc: stable Link: https://lore.kernel.org/r/20191023103558.51862-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_dw.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -386,10 +386,10 @@ static int dw8250_probe(struct platform_ { struct uart_8250_port uart = {}, *up = &uart; struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); - int irq = platform_get_irq(pdev, 0); struct uart_port *p = &up->port; struct device *dev = &pdev->dev; struct dw8250_data *data; + int irq; int err; u32 val; @@ -398,11 +398,9 @@ static int dw8250_probe(struct platform_ return -EINVAL; } - if (irq < 0) { - if (irq != -EPROBE_DEFER) - dev_err(dev, "cannot get irq\n"); + irq = platform_get_irq(pdev, 0); + if (irq < 0) return irq; - } spin_lock_init(&p->lock); p->mapbase = regs->start;