From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FBBC2D0C6 for ; Wed, 11 Dec 2019 15:24:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF9D72173E for ; Wed, 11 Dec 2019 15:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077851; bh=H98GnpD26pXvlIkDV9eWewTvkBxdUfTpH83ifvp4PdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Xp6Ng7jO+Tt/pNrNTpiQJLJ+bGJG15p0Y5uAPjHS/JvILEF3tBY875YAmT+ERNek6 T89GDzVhdyWLYEQ75RHs8gOVDx2yi/9wO7WbRXm6zeE+egT5TyMhp+6bzgvol317EB csKtBtQAHA0OwrYofMjC9hg2ehL3Rw8g1hKo9vGw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732807AbfLKPYJ (ORCPT ); Wed, 11 Dec 2019 10:24:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:55302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732648AbfLKPYE (ORCPT ); Wed, 11 Dec 2019 10:24:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 559312077B; Wed, 11 Dec 2019 15:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077843; bh=H98GnpD26pXvlIkDV9eWewTvkBxdUfTpH83ifvp4PdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ez0uS6PVVXP257HIK7cSxC/fCVDozFyTqtAJC0YbOCRRHi+TQEKRB4xu81VsDAqYM EqgWoAJ1LcbL9BqVFP4KNRxfrr+ywAR/PzYilV+rRYCycUc0olbe3M2/roWaI5gkiE 3YR98RRVWM4EjO1/W/BIwbPVeWdlUKE37SmAT58k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yuchung Cheng , Eric Dumazet , Neal Cardwell , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 155/243] tcp: fix off-by-one bug on aborting window-probing socket Date: Wed, 11 Dec 2019 16:05:17 +0100 Message-Id: <20191211150349.632370408@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yuchung Cheng [ Upstream commit 3976535af0cb9fe34a55f2ffb8d7e6b39a2f8188 ] Previously there is an off-by-one bug on determining when to abort a stalled window-probing socket. This patch fixes that so it is consistent with tcp_write_timeout(). Signed-off-by: Yuchung Cheng Signed-off-by: Eric Dumazet Signed-off-by: Neal Cardwell Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/tcp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index c719a41d2eba2..50b15e1c633b4 100644 --- a/net/ipv4/tcp_timer.c +++ b/net/ipv4/tcp_timer.c @@ -378,7 +378,7 @@ static void tcp_probe_timer(struct sock *sk) return; } - if (icsk->icsk_probes_out > max_probes) { + if (icsk->icsk_probes_out >= max_probes) { abort: tcp_write_err(sk); } else { /* Only send another probe if we didn't close things up. */ -- 2.20.1