From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4328AC43603 for ; Wed, 11 Dec 2019 15:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C5C020663 for ; Wed, 11 Dec 2019 15:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077254; bh=k9dpj1B8c41icXDmGXJ4tL8WRoMBs6eIybywBy7mBVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o3dOK/gdc3DLdFUZn7JNDKv2gi9v0DBTBzqWkjBMaIMLAXNwTKSLRwvbE8saOoAq+ ycvKeNTs0UniFQypA97Fh9K07LO/PxZtOhqs37ZZR2AVqQ8CHbDDN6yZ9iTv7T+mhk lHUELFfkk3RsyOqPZ1ua8VULBpY4jZgMOdDJFlnc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731403AbfLKPOM (ORCPT ); Wed, 11 Dec 2019 10:14:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:37080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730331AbfLKPNa (ORCPT ); Wed, 11 Dec 2019 10:13:30 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A12CF208C3; Wed, 11 Dec 2019 15:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077209; bh=k9dpj1B8c41icXDmGXJ4tL8WRoMBs6eIybywBy7mBVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wFbTK89bLpnS/iCAF2NPvF/0kJQw+WJCWj/Ueh76608vOEkTz+4S9JjWNxnrarCFU 70HETL0VcgaVB1vyU5o8Z/GvqYnsE2wdgUjW3h8JcIEH7bzKP8Ljiu8iGPoQriZavz TaJDX+IZg/bXvzDZ6kPTnTTfJxIUlP04jTAqNdGw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: peter chang , Jack Wang , Deepak Ukey , Viswas G , "Martin K . Petersen" , Sasha Levin , pmchba@pmcs.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 091/134] scsi: pm80xx: Fix for SATA device discovery Date: Wed, 11 Dec 2019 10:11:07 -0500 Message-Id: <20191211151150.19073-91-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211151150.19073-1-sashal@kernel.org> References: <20191211151150.19073-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: peter chang [ Upstream commit ce21c63ee995b7a8b7b81245f2cee521f8c3c220 ] Driver was missing complete() call in mpi_sata_completion which result in SATA abort error handling timing out. That causes the device to be left in the in_recovery state so subsequent commands sent to the device fail and the OS removes access to it. Link: https://lore.kernel.org/r/20191114100910.6153-2-deepak.ukey@microchip.com Acked-by: Jack Wang Signed-off-by: peter chang Signed-off-by: Deepak Ukey Signed-off-by: Viswas G Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index 73261902d75d5..161bf4760eac7 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -2382,6 +2382,8 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) pm8001_printk("task 0x%p done with io_status 0x%x" " resp 0x%x stat 0x%x but aborted by upper layer!\n", t, status, ts->resp, ts->stat)); + if (t->slow_task) + complete(&t->slow_task->completion); pm8001_ccb_task_free(pm8001_ha, t, ccb, tag); } else { spin_unlock_irqrestore(&t->task_state_lock, flags); -- 2.20.1