From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B3BC43603 for ; Wed, 11 Dec 2019 15:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A576A2464B for ; Wed, 11 Dec 2019 15:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078909; bh=Lmchv2zluPAuLaPCeDYi0HgXg3aUPCYzmqEYwJ2OVE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UsnQ6QG4OTSiLrbQ8A+zOmS/jueH1fHlLLzVkwxhuuKsbG/fAjneGsxYOwmU2IDIf /5BgRDmBaLMt1lDjB9vC2tHHt0OfLtaQ3xnyyd1UbJv6ra1kjxw6nnPqw1qUrQHyqM 5sE8INsH7M/El05DW/fK5XSxTmsA78jb/7KwCqU8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388394AbfLKPls (ORCPT ); Wed, 11 Dec 2019 10:41:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:33800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733179AbfLKP1y (ORCPT ); Wed, 11 Dec 2019 10:27:54 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2FCD24671; Wed, 11 Dec 2019 15:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078074; bh=Lmchv2zluPAuLaPCeDYi0HgXg3aUPCYzmqEYwJ2OVE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lsQJRAz15todzXEE5S3XaKSByKQnwZJuJwxFKl/u2r/2edKKB2c9FnFb97sBpAT1g CyCzss3oX6TaQLtgDR+SPHr1Qw1F/Jv7DwdTMAFe/y/cIIv3oPhfOWRAIaYW5EYFh9 tXOG3zRUGFMIwd/5xwwnkWQ3SgEZdGLyaCenQc+A= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Masahiro Yamada , Sasha Levin Subject: [PATCH AUTOSEL 4.19 65/79] scripts/kallsyms: fix definitely-lost memory leak Date: Wed, 11 Dec 2019 10:26:29 -0500 Message-Id: <20191211152643.23056-65-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211152643.23056-1-sashal@kernel.org> References: <20191211152643.23056-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit 21915eca088dc271c970e8351290e83d938114ac ] build_initial_tok_table() overwrites unused sym_entry to shrink the table size. Before the entry is overwritten, table[i].sym must be freed since it is malloc'ed data. This fixes the 'definitely lost' report from valgrind. I ran valgrind against x86_64_defconfig of v5.4-rc8 kernel, and here is the summary: [Before the fix] LEAK SUMMARY: definitely lost: 53,184 bytes in 2,874 blocks [After the fix] LEAK SUMMARY: definitely lost: 0 bytes in 0 blocks Signed-off-by: Masahiro Yamada Signed-off-by: Sasha Levin --- scripts/kallsyms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index 31ed7f3f0e157..4b2711c23f4ed 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -491,6 +491,8 @@ static void build_initial_tok_table(void) table[pos] = table[i]; learn_symbol(table[pos].sym, table[pos].len); pos++; + } else { + free(table[i].sym); } } table_cnt = pos; -- 2.20.1