From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Hillf Danton <hdanton@sina.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [RFC 1/4] workqueue: fix selecting cpu for queuing work
Date: Wed, 11 Dec 2019 18:07:35 -0500 [thread overview]
Message-ID: <20191211230735.r5xpmgwfjjkzxwaf@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <20191211105919.10652-1-hdanton@sina.com>
[please cc maintainers]
On Wed, Dec 11, 2019 at 06:59:19PM +0800, Hillf Danton wrote:
> Round robin is needed only for unbound workqueue and wq_unbound_cpumask
> has nothing to do with standard workqueues, so we have to select cpu in
> case of WORK_CPU_UNBOUND also with workqueue type taken into account.
Good catch. I'd include something like this in the changelog.
Otherwise, work queued on a bound workqueue with WORK_CPU_UNBOUND might
not prefer the local CPU if wq_unbound_cpumask is non-empty and doesn't
include that CPU.
With that you can add
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
next parent reply other threads:[~2019-12-11 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191211104601.16468-1-hdanton@sina.com>
[not found] ` <20191211105919.10652-1-hdanton@sina.com>
2019-12-11 23:07 ` Daniel Jordan [this message]
2020-01-23 22:37 ` [RFC 1/4] workqueue: fix selecting cpu for queuing work Daniel Jordan
[not found] ` <20191211112229.22652-1-hdanton@sina.com>
2019-12-11 23:25 ` [RFC 3/4] workqueue: reap dead pool workqueue on " Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211230735.r5xpmgwfjjkzxwaf@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=hdanton@sina.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).