From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0366AC43603 for ; Thu, 12 Dec 2019 07:53:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CECC32173E for ; Thu, 12 Dec 2019 07:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E6CVo+lY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728234AbfLLHx4 (ORCPT ); Thu, 12 Dec 2019 02:53:56 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33493 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbfLLHxh (ORCPT ); Thu, 12 Dec 2019 02:53:37 -0500 Received: by mail-wr1-f65.google.com with SMTP id b6so1640742wrq.0 for ; Wed, 11 Dec 2019 23:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y0w6MnW3oZvs4i15UPLA0/120XiFldb3t4/pTdGFLw0=; b=E6CVo+lYFHxy1yyahd2inU7r/9j3l2DqXTlgipfrVkba/Jl2TfefTcPbRpdk8V0joZ RrByorq//rGjnAx9dl6Ds8d1hVHQMVMJhvfdTct0nw8PWLMrJaKjYptNvapLIHAVomiz htwxe3N2JqfqGEKKiwiKorD6j6mdVm2KOQ0LcE2wIhLBC95mCMriqAdgeqfUuFHLYPRG W2nGPHGhJftyqpmKGwVDVn2lyCd5W+kjHCKKGS2g/LmLrLlb6lKDCxtXaXGsTF1cPYXR Yf9L/yBYDWcK+0GKQScCuQCENTeoDQoNRHAP1miPGeCYcuScpp8xi3XL/JJ+p+ctcJ0W z9vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y0w6MnW3oZvs4i15UPLA0/120XiFldb3t4/pTdGFLw0=; b=I6ZsMG7kEkEpgc+w2RpiirfYgR3jxl0WOsJ6apEoSUNfywY6pZnEOwU641vBloDvzE GClYRDnJMK3LKmKlqSFyu+b4aiMom55phClezTzF0lLQL4UomfD0X/bPNsys2lL6VvGH 0fxVvWEiymBvkNvYr71e4q1jz02+uEjg1lWPRO2JJ/42Ai7R5k5CmfL5vVVqC1KdEoD9 wLqix8Odngt6lTQeFyamfTapUC3FJfV/rsEneww6eVNbyuCEIgPfrm5TYzYH2iI2dFX2 8EPJrjkGV6ZeX8JVpZp9cbGsJ45nY3/R9n+YNf1y9Mh6evQ3QanPON26UuimBZpZaajF EBAw== X-Gm-Message-State: APjAAAUnzKERZjT2MYPs77/4nwS6Zcvhg+bSgboTq1ftJs+KMjCHKpfK Ch9+wRL59jTwnBxJ16knRYtBmw== X-Google-Smtp-Source: APXvYqwytfBf126ULinW5oFqdBQeWvCz2VVUAU2XhFKvinoMG4AvjJx0JLgTIa8YEq6lsKANcL889Q== X-Received: by 2002:a5d:5708:: with SMTP id a8mr4838423wrv.79.1576137215643; Wed, 11 Dec 2019 23:53:35 -0800 (PST) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id x6sm5636742wmi.44.2019.12.11.23.53.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Dec 2019 23:53:35 -0800 (PST) From: Georgi Djakov To: gregkh@linuxfoundation.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Georgi Djakov , Dmitry Osipenko , Bjorn Andersson , stable@vger.kernel.org Subject: [PATCH 2/4] interconnect: qcom: sdm845: Walk the list safely on node removal Date: Thu, 12 Dec 2019 09:53:30 +0200 Message-Id: <20191212075332.16202-3-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191212075332.16202-1-georgi.djakov@linaro.org> References: <20191212075332.16202-1-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As we will remove items off the list using list_del(), we need to use the safe version of list_for_each_entry(). Fixes: b5d2f741077a ("interconnect: qcom: Add sdm845 interconnect provider driver") Reported-by: Dmitry Osipenko Reviewed-by: Bjorn Andersson Signed-off-by: Georgi Djakov Cc: # v5.3+ --- drivers/interconnect/qcom/sdm845.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c index 502a6c22b41e..387267ee9648 100644 --- a/drivers/interconnect/qcom/sdm845.c +++ b/drivers/interconnect/qcom/sdm845.c @@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev) { struct qcom_icc_provider *qp = platform_get_drvdata(pdev); struct icc_provider *provider = &qp->provider; - struct icc_node *n; + struct icc_node *n, *tmp; - list_for_each_entry(n, &provider->nodes, node_list) { + list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) { icc_node_del(n); icc_node_destroy(n->id); }