linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: arnd@arndb.de, peng.hao2@zte.com.cn, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: pvpanic: add crash loaded event
Date: Thu, 12 Dec 2019 14:01:55 +0100	[thread overview]
Message-ID: <20191212130155.GA1544206@kroah.com> (raw)
In-Reply-To: <20191212123226.1879155-1-pizhenwei@bytedance.com>

On Thu, Dec 12, 2019 at 08:32:26PM +0800, zhenwei pi wrote:
> Some users prefer kdump tools to generate guest kernel dumpfile,
> at the same time, need a out-of-band kernel panic event.
> 
> Currently if booting guest kernel with 'crash_kexec_post_notifiers',
> QEMU will recieve PVPANIC_PANICKED event and stop VM. If booting
> guest kernel without 'crash_kexec_post_notifiers', guest will not
> call notifier chain.
> 
> Add PVPANIC_CRASH_LOADED bit for pvpanic event, it means that guest
> actually hit a kernel panic, but kernel wants to handle by itself.
> 
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>  drivers/misc/pvpanic.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 95ff7c5a1dfb..a8cc96c90550 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/acpi.h>
>  #include <linux/kernel.h>
> +#include <linux/kexec.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> @@ -19,6 +20,7 @@
>  static void __iomem *base;
>  
>  #define PVPANIC_PANICKED        (1 << 0)
> +#define PVPANIC_CRASH_LOADED    (1 << 1)

BIT(1)?

>  MODULE_AUTHOR("Hu Tao <hutao@cn.fujitsu.com>");
>  MODULE_DESCRIPTION("pvpanic device driver");
> @@ -34,7 +36,13 @@ static int
>  pvpanic_panic_notify(struct notifier_block *nb, unsigned long code,
>  		     void *unused)
>  {
> -	pvpanic_send_event(PVPANIC_PANICKED);
> +	unsigned int event = PVPANIC_PANICKED;
> +
> +	if (kexec_crash_loaded())
> +		event = PVPANIC_CRASH_LOADED;
> +
> +	pvpanic_send_event(event);

Who gets this event to know that the above new bit is set or not?

thanks,

greg k-h

  reply	other threads:[~2019-12-12 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 12:32 [PATCH] misc: pvpanic: add crash loaded event zhenwei pi
2019-12-12 13:01 ` Greg KH [this message]
     [not found]   ` <0364f87c-7ad0-0208-fb03-d5f17d45ab73@bytedance.com>
2019-12-12 13:35     ` [External] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212130155.GA1544206@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.hao2@zte.com.cn \
    --cc=pizhenwei@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).