From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AE8C00454 for ; Thu, 12 Dec 2019 16:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BAC92073B for ; Thu, 12 Dec 2019 16:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576167023; bh=UlKAh17aJAqMckv7yl8SJYoJdjl6lSz9fkqa/MlVAvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iEa5pyWZHPGy3KuLxZsbxOYxifZIufXW4yXvbeIEPtjuupluXM5BAbO8SJPRilXgn 9kb9+gRs4JCbB9eVCNU70HnvyJsTq6X58MdzpSpf8d4ZaY5a/wjILZp+IOJvQcHCs2 jClCYuHswsIaSgAhyrjus5fW8BvAnggocmfim6tk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729867AbfLLQKW (ORCPT ); Thu, 12 Dec 2019 11:10:22 -0500 Received: from foss.arm.com ([217.140.110.172]:52050 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729731AbfLLQKW (ORCPT ); Thu, 12 Dec 2019 11:10:22 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5435030E; Thu, 12 Dec 2019 08:10:21 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C7FCC3F6CF; Thu, 12 Dec 2019 08:10:20 -0800 (PST) Date: Thu, 12 Dec 2019 16:10:19 +0000 From: Mark Brown To: Marco Felsch Cc: Adam Thomson , Support Opensource , "lee.jones@linaro.org" , "robh+dt@kernel.org" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "joel@jms.id.au" , "andrew@aj.id.au" , "lgirdwood@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Message-ID: <20191212161019.GF4310@sirena.org.uk> References: <20191129172537.31410-1-m.felsch@pengutronix.de> <20191129172537.31410-4-m.felsch@pengutronix.de> <20191204134631.GT1998@sirena.org.uk> <20191210094144.mxximpuouchy3fqu@pengutronix.de> <20191211170918.q7kqkd4lrwwp7jl3@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SxgehGEc6vB0cZwN" Content-Disposition: inline In-Reply-To: <20191211170918.q7kqkd4lrwwp7jl3@pengutronix.de> X-Cookie: We have DIFFERENT amounts of HAIR -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SxgehGEc6vB0cZwN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 11, 2019 at 06:09:18PM +0100, Marco Felsch wrote: > so one argument more for my solution. Also we don't configure the "pad" > to be a vsel/ena-pin. The hw-pad can only be a gpio or has an alternate > function (WDKICK for GPIO0, Seq. SYS_EN for GPIO2, Seq. PWR_EN for GPIO4). > Instead we tell the regulator to use _this_ GPIO e.g. for voltage > selection so we go the other way around. My last argument why pinctrl > isn't the correct place is that the GPIO1 can be used for > regulator-0:vsel-in and for regulator-1:enable-in. So this pad would > have different states which is invalid IMHO. Note that there's two bits to my concern - one is if we should be using gpiolib or pinctrl, the other is what's driving the input (whichever API it's configured through) which didn't seem to be mentioned. --SxgehGEc6vB0cZwN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3yZmoACgkQJNaLcl1U h9Ax8Af+NzakOK4jJKQRyY0wT3cczNnHphTUSbJ1zrH7fM+0K/2I8E6301iWfElB un6MYIjc8w5BMwLzMZ+Vjd6ZTheXHXnKeJPNNv69Fh4tUOS2vUQ2qRCtKvkLKF5q g5xwlTsMi3sBeFJljAoDfttiTvqj5XT1BERgNNPp8MSzQ2FWvKj+rDn+kvNq//Os Qf425pla6Go2FYVUSuauWZCQxWkqW7uDzCeDxpNurGvHhTCYNHQf8hAtkyGoGm6V UfGnSkypXK7vDrS25gYNIuyDN1RAjGhQIhBHuU3QLzLFNa1ozZ7xtNxnl3pcFvk9 fzbFegJweraLhfQ7SYhcpiTJUZKQfA== =pK4s -----END PGP SIGNATURE----- --SxgehGEc6vB0cZwN--