linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/
@ 2019-12-12 21:00 Alexey Dobriyan
  2019-12-12 21:09 ` Peter Zijlstra
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2019-12-12 21:00 UTC (permalink / raw)
  To: peterz; +Cc: linux-kernel

> We could move the kernel to C++ and write:
> 
> 	std::remove_volatile<typeof(p)>::type __p = (p);
> 
> /me runs like hell...

Did you just said I can send "struct sched_domain::private" and
"struct wait_queue_entry::private" rename?
:^)

Doable but not until C++20. constinit and designated initializers are
pretty mandatory.

Debian GNU/Linux 8 debian88 ttyS0

debian88 login: root
Password:
Last login: Thu Sep 19 01:04:29 +03 2019 on tty1
Linux debian88 5.3.0+ #1 SMP PREEMPT Thu Sep 19 01:02:26 +03 2019 x86_64
root@debian88:~# cat /proc/$(pgrep sshd)/stack
[<0>] _ZL9do_selectiP11fd_set_bitsP10timespec64+0x5ac/0x750
[<0>] _Z15core_sys_selectiP15__kernel_fd_setS0_S0_P10timespec64+0x143/0x260
[<0>] __x64_sys_select+0xa7/0xf0
[<0>] do_syscall_64+0x3b/0xe7
[<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/
  2019-12-12 21:00 READ_ONCE() + STACKPROTECTOR_STRONG == :/ Alexey Dobriyan
@ 2019-12-12 21:09 ` Peter Zijlstra
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2019-12-12 21:09 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: linux-kernel

On Fri, Dec 13, 2019 at 12:00:52AM +0300, Alexey Dobriyan wrote:
> > We could move the kernel to C++ and write:
> > 
> > 	std::remove_volatile<typeof(p)>::type __p = (p);
> > 
> > /me runs like hell...
> 
> Did you just said I can send "struct sched_domain::private" and
> "struct wait_queue_entry::private" rename?
> :^)

I don't believe those are the only usage of C++ keywords. IIRC I'm using
'class' somewhere as well.

> Doable but not until C++20. constinit and designated initializers are
> pretty mandatory.
> 
> Debian GNU/Linux 8 debian88 ttyS0
> 
> debian88 login: root
> Password:
> Last login: Thu Sep 19 01:04:29 +03 2019 on tty1
> Linux debian88 5.3.0+ #1 SMP PREEMPT Thu Sep 19 01:02:26 +03 2019 x86_64
> root@debian88:~# cat /proc/$(pgrep sshd)/stack
> [<0>] _ZL9do_selectiP11fd_set_bitsP10timespec64+0x5ac/0x750
> [<0>] _Z15core_sys_selectiP15__kernel_fd_setS0_S0_P10timespec64+0x143/0x260

Argh.. I forgot how I hated mangled names.

> [<0>] __x64_sys_select+0xa7/0xf0
> [<0>] do_syscall_64+0x3b/0xe7
> [<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-12 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 21:00 READ_ONCE() + STACKPROTECTOR_STRONG == :/ Alexey Dobriyan
2019-12-12 21:09 ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).