From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D6EC3496E for ; Fri, 13 Dec 2019 20:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09210246A2 for ; Fri, 13 Dec 2019 20:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576269390; bh=PYvRPNX/Qngmz1mGzU9X5yZkWXb1xrogAUUZ1twogYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GKA1vrGwdYPI1ykNIdhAPkgEol4o+1RD4uWCKagUYxHQqCcSuSge0bckQQr9fSq+z OCAo4lU1N+h6vbPKarCjhPPkItrvGW4XG8k/W5HIXSzEVfVYHI2ZgPtKYsLCoSZE93 J9zmbD1LHJXvUwZnLHaK+YHZg+uXoE0YL6N+TQB8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfLMLme (ORCPT ); Fri, 13 Dec 2019 06:42:34 -0500 Received: from foss.arm.com ([217.140.110.172]:56110 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbfLMLme (ORCPT ); Fri, 13 Dec 2019 06:42:34 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2F0C1045; Fri, 13 Dec 2019 03:42:33 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 233043F718; Fri, 13 Dec 2019 03:42:32 -0800 (PST) Date: Fri, 13 Dec 2019 11:42:31 +0000 From: Mark Brown To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, linux-leds@vger.kernel.org, Linux Kernel Mailing List , linux-spi , Jacek Anaszewski , Pavel Machek , Linux ARM , Dan Murphy Subject: Re: [RFC 04/25] spi: gpio: Implement LSB First bitbang support Message-ID: <20191213114231.GC4644@sirena.org.uk> References: <20191212033952.5967-1-afaerber@suse.de> <20191212033952.5967-5-afaerber@suse.de> <9b4b6287-c1d9-1b41-88a8-7ac9fe222642@suse.de> <20191212171922.GM4310@sirena.org.uk> <70bf4954-d7ab-e300-017c-c743a40162a4@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OBd5C1Lgu00Gd/Tn" Content-Disposition: inline In-Reply-To: <70bf4954-d7ab-e300-017c-c743a40162a4@suse.de> X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OBd5C1Lgu00Gd/Tn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 12, 2019 at 10:08:24PM +0100, Andreas F=E4rber wrote: > Am 12.12.19 um 18:19 schrieb Mark Brown: > >>>> Duplicate the inline helpers bitbang_txrx_be_cpha{0,1} as LE version= s. > >>>> Make checkpatch.pl happy by changing "unsigned" to "unsigned int". > > Separate patch for this? > For the checkpatch cleanup? Or helpers preparation vs. spi-gpio.c usage? At least the checkpatch cleanup. > > Yeah, I don't think there's any great options here with the potential > > performance issues - probably the nicest thing would be to autogenerate > > lots of variants but I think that's far more trouble than it's worth. > Maybe add another code comment to revisit that idea later then? Sure, if you like. --OBd5C1Lgu00Gd/Tn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zeSYACgkQJNaLcl1U h9BeaQf9Gwa9v/4JBqlU2EYPQesdyqtMrKKm+f5AChrzJThgZFgCyrfqTR/3uWBy /SF8lSe7KY9OyztUKw5g+7WLB/oBrMXPlm40GKafsaKC0eEeb9is09ZCnxOkDKDU T2DQuGVbpQ15A+764B2O2YmoZ4MOoQft6BCv/eqFHtZ7PXrE/KkR9ZkBRbNGlZdg koWMA7InOnyM2jVONLQIkmicLLi2R/ADJjV3MMhRrfamY6xEvu7e7IrPUdFV2HHl dPj1nFNsrgQwPG4Ns4+ohrTwtjwOycakEMqD9CwhRp8mw1XE7Ru5no3LB/zxVbqd q00vWhYLcJ4R+sl55+bXCitUFEDGKg== =fXQg -----END PGP SIGNATURE----- --OBd5C1Lgu00Gd/Tn--