From: Rob Herring <robh@kernel.org>
To: amirmizi6@gmail.com
Cc: Eyal.Cohen@nuvoton.com, jarkko.sakkinen@linux.intel.com,
oshrialkoby85@gmail.com, alexander.steffen@infineon.com,
mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
ayna@linux.vnet.ibm.com, Dan.Morav@nuvoton.com,
oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com,
amir.mizinski@nuvoton.com
Subject: Re: [PATCH v2 4/5] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options
Date: Fri, 13 Dec 2019 16:36:23 -0600 [thread overview]
Message-ID: <20191213223623.GA14809@bogus> (raw)
In-Reply-To: <20191202133332.178110-5-amirmizi6@gmail.com>
On Mon, Dec 02, 2019 at 03:33:31PM +0200, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
>
> Added a YAML schema to support tpm tis i2c realted dt-bindings for the I2c PTP based physical layer.
Wrap your commmit message. And TPM, TIS?, and I2C should be capitalized.
>
> Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
> ---
> .../bindings/security/tpm/tpm-tis-i2c.yaml | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
Please read my comments on v1 (The first v1 from 11/10, not the 2nd v1
you sent).
Rob
next prev parent reply other threads:[~2019-12-13 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 13:33 [PATCH v2 0/5] add tpm i2c ptp driver amirmizi6
2019-12-02 13:33 ` [PATCH v2 1/5] char: tpm: Make implementation of read16 read32 write32 optional amirmizi6
2019-12-02 13:33 ` [PATCH v2 2/5] char: tpm: Add check_data handle to tpm_tis_phy_ops in order to check data integrity amirmizi6
2019-12-02 13:33 ` [PATCH v2 3/5] char: tpm: rewrite "tpm_tis_req_canceled()" amirmizi6
2019-12-02 13:33 ` [PATCH v2 4/5] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options amirmizi6
2019-12-13 22:36 ` Rob Herring [this message]
2019-12-16 13:53 ` Amir Mizinski
2019-12-16 14:17 ` Rob Herring
2019-12-02 13:33 ` [PATCH v2 5/5] char: tpm: add tpm_tis_i2c driver amirmizi6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213223623.GA14809@bogus \
--to=robh@kernel.org \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=amirmizi6@gmail.com \
--cc=arnd@arndb.de \
--cc=ayna@linux.vnet.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).