From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: od@zcrc.me, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 4/6] usb: musb: jz4740: Rename platform_device field in priv struct
Date: Sat, 14 Dec 2019 23:11:24 +0100 [thread overview]
Message-ID: <20191214221126.93116-4-paul@crapouillou.net> (raw)
In-Reply-To: <20191214221126.93116-1-paul@crapouillou.net>
Name the platform_device pointer 'pdev' instead of 'musb'. Since the
driver also deal with pointers to 'struct musb', it can be very
confusing to have a pointer named after this struct but with a different
type.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/usb/musb/jz4740.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c
index 3410e6b01bac..e2baa1b6bad6 100644
--- a/drivers/usb/musb/jz4740.c
+++ b/drivers/usb/musb/jz4740.c
@@ -17,7 +17,7 @@
#include "musb_core.h"
struct jz4740_glue {
- struct platform_device *musb;
+ struct platform_device *pdev;
struct clk *clk;
};
@@ -151,7 +151,7 @@ static int jz4740_probe(struct platform_device *pdev)
musb->dev.dma_mask = &musb->dev.coherent_dma_mask;
musb->dev.coherent_dma_mask = DMA_BIT_MASK(32);
- glue->musb = musb;
+ glue->pdev = musb;
glue->clk = clk;
platform_set_drvdata(pdev, glue);
@@ -188,7 +188,7 @@ static int jz4740_remove(struct platform_device *pdev)
{
struct jz4740_glue *glue = platform_get_drvdata(pdev);
- platform_device_unregister(glue->musb);
+ platform_device_unregister(glue->pdev);
clk_disable_unprepare(glue->clk);
return 0;
--
2.24.0
next prev parent reply other threads:[~2019-12-14 22:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 22:11 [PATCH 1/6] usb: musb: jz4740: Suppress useless field in priv structure Paul Cercueil
2019-12-14 22:11 ` [PATCH 2/6] usb: musb: jz4740: Add local dev variable to clean up probe Paul Cercueil
2019-12-14 22:11 ` [PATCH 3/6] usb: musb: jz4740: Constify jz4740_musb_pdata struct Paul Cercueil
2019-12-14 22:11 ` Paul Cercueil [this message]
2019-12-14 22:11 ` [PATCH 5/6] usb: musb: jz4740: Comments fix Paul Cercueil
2019-12-14 22:11 ` [PATCH 6/6] usb: musb: jz4740: Whitespace and indentation fixes Paul Cercueil
2019-12-16 17:19 ` [PATCH 1/6] usb: musb: jz4740: Suppress useless field in priv structure Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191214221126.93116-4-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).