From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: stmmac: Let TX and RX interrupts be independently enabled/disabled
Date: Mon, 16 Dec 2019 12:14:04 -0800 [thread overview]
Message-ID: <20191216121404.43966b89@cakuba.netronome.com> (raw)
In-Reply-To: <BN8PR12MB3266288303A6CA6C3CAA5E6CD3510@BN8PR12MB3266.namprd12.prod.outlook.com>
On Mon, 16 Dec 2019 09:18:50 +0000, Jose Abreu wrote:
> > > @@ -3759,24 +3777,18 @@ static int stmmac_napi_poll_tx(struct napi_struct *napi, int budget)
> > > struct stmmac_channel *ch =
> > > container_of(napi, struct stmmac_channel, tx_napi);
> > > struct stmmac_priv *priv = ch->priv_data;
> > > - struct stmmac_tx_queue *tx_q;
> > > u32 chan = ch->index;
> > > int work_done;
> > >
> > > priv->xstats.napi_poll++;
> > >
> > > - work_done = stmmac_tx_clean(priv, DMA_TX_SIZE, chan);
> > > - work_done = min(work_done, budget);
> > > -
> > > - if (work_done < budget)
> > > - napi_complete_done(napi, work_done);
> > > + work_done = stmmac_tx_clean(priv, budget, chan);
> > > + if (work_done < budget && napi_complete_done(napi, work_done)) {
> >
> > Not really related to this patch, but this looks a little suspicious.
> > I think the TX completions should all be processed regardless of the
> > budget. The budget is for RX.
>
> Well but this is a TX NAPI ... Shouldn't it be limited to prevent CPU
> starvation ?
It is a bit confusing, but at least netpoll expects the TX completions
to be processed with zero budget. Check out poll_one_napi().
next prev parent reply other threads:[~2019-12-16 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:54 [PATCH net-next 0/4] net: stmmac: Improvements for -next Jose Abreu
2019-12-10 19:54 ` [PATCH net-next 1/4] net: stmmac: Print more information in DebugFS DMA Capabilities file Jose Abreu
2019-12-10 19:54 ` [PATCH net-next 2/4] net: stmmac: Always arm TX Timer at end of transmission start Jose Abreu
2019-12-10 19:54 ` [PATCH net-next 3/4] net: stmmac: Let TX and RX interrupts be independently enabled/disabled Jose Abreu
2019-12-14 20:36 ` Jakub Kicinski
2019-12-16 9:18 ` Jose Abreu
2019-12-16 20:14 ` Jakub Kicinski [this message]
2019-12-10 19:54 ` [PATCH net-next 4/4] net: stmmac: Always use TX coalesce timer value when rescheduling Jose Abreu
2019-12-14 20:28 ` Jakub Kicinski
2019-12-16 9:20 ` Jose Abreu
2019-12-16 20:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216121404.43966b89@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).