From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87050C43603 for ; Mon, 16 Dec 2019 13:15:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CA4C2067C for ; Mon, 16 Dec 2019 13:15:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="RoYqbfkD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727920AbfLPNPP (ORCPT ); Mon, 16 Dec 2019 08:15:15 -0500 Received: from vps.xff.cz ([195.181.215.36]:45156 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727897AbfLPNPO (ORCPT ); Mon, 16 Dec 2019 08:15:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1576502113; bh=91BvEmwihOD7qAEzR/XIWeG45IH0J4HCzYdZSVFlRxE=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=RoYqbfkDdb6FsoIaYhxjz2Ad0BUS4hazQTN/VAep2LGC1sC45PMPkNj4TcRaOpEXw +lKGjAZYjdlfM+jDDL56VQCNXbDNQ7WdNYR+kslOaCF46jOuaEoESXrWZU3H2eSBaD zmMbFM82pOEPCylQ5rtxHEj8WW5SZpGoMRvGB5xg= Date: Mon, 16 Dec 2019 14:15:12 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stefan Wahren , Marcel Holtmann , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 133/350] Bluetooth: hci_bcm: Fix RTS handling during startup Message-ID: <20191216131512.c5x5ltndmdambdf4@core.my.home> Mail-Followup-To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stefan Wahren , Marcel Holtmann , linux-bluetooth@vger.kernel.org References: <20191210210735.9077-1-sashal@kernel.org> <20191210210735.9077-94-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210210735.9077-94-sashal@kernel.org> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Dec 10, 2019 at 04:03:58PM -0500, Sasha Levin wrote: > From: Stefan Wahren > > [ Upstream commit 3347a80965b38f096b1d6f995c00c9c9e53d4b8b ] > > The RPi 4 uses the hardware handshake lines for CYW43455, but the chip > doesn't react to HCI requests during DT probe. The reason is the inproper > handling of the RTS line during startup. According to the startup > signaling sequence in the CYW43455 datasheet, the hosts RTS line must > be driven after BT_REG_ON and BT_HOST_WAKE. > > Signed-off-by: Stefan Wahren > Signed-off-by: Marcel Holtmann > Signed-off-by: Sasha Levin > --- > drivers/bluetooth/hci_bcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index 7646636f2d183..0f73f6a686cb7 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -445,9 +445,11 @@ static int bcm_open(struct hci_uart *hu) > > out: > if (bcm->dev) { > + hci_uart_set_flow_control(hu, true); > hu->init_speed = bcm->dev->init_speed; > hu->oper_speed = bcm->dev->oper_speed; > err = bcm_gpio_set_power(bcm->dev, true); > + hci_uart_set_flow_control(hu, false); > if (err) > goto err_unset_hu; > } This causes bluetooth breakage (degraded bluetooth performance, due to failure to switch to higher baudrate) for Orange Pi 3 board: [ 3.839134] Bluetooth: hci0: command 0xfc18 tx timeout [ 11.999136] Bluetooth: hci0: BCM: failed to write update baudrate (-110) [ 12.004613] Bluetooth: hci0: Failed to set baudrate [ 12.123187] Bluetooth: hci0: BCM: chip id 130 [ 12.128398] Bluetooth: hci0: BCM: features 0x0f [ 12.154686] Bluetooth: hci0: BCM4345C5 [ 12.157165] Bluetooth: hci0: BCM4345C5 (003.006.006) build 0000 [ 15.343684] Bluetooth: hci0: BCM4345C5 (003.006.006) build 0038 I suggest not pushing this to stable. regards, Ondrej > 2.20.1 >