From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE7EC2D0BF for ; Mon, 16 Dec 2019 14:23:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A0EA205ED for ; Mon, 16 Dec 2019 14:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576506197; bh=bf/Eh6+RNsClsF0CYZLmzC8pbuP0NjhGX+4C33oAHpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1mphxzfkhIqSI2fZLVUw20iczJAa4tZeJjvsT2TrQn/Cy+YP/qSB0UC9N92SCN2z3 +j38jMtPm1vE0tHeufvB21Hik6CZlxrU/a1FGG8AthaTIyMmnags36JqmLdNWXAP/p /CLcq0DuRMqUtDf59FmrKl+EP9DgOwHAZE8NyQ98= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbfLPOXQ (ORCPT ); Mon, 16 Dec 2019 09:23:16 -0500 Received: from foss.arm.com ([217.140.110.172]:57116 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbfLPOXP (ORCPT ); Mon, 16 Dec 2019 09:23:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39B091FB; Mon, 16 Dec 2019 06:23:15 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC44E3F718; Mon, 16 Dec 2019 06:23:14 -0800 (PST) Date: Mon, 16 Dec 2019 14:23:13 +0000 From: Mark Brown To: Daniel Mack Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lee.jones@linaro.org, lars@metafoo.de, pascal.huerst@gmail.com Subject: Re: [PATCH 10/10] ASoC: Add codec component for AD242x nodes Message-ID: <20191216142313.GD4161@sirena.org.uk> References: <20191209183511.3576038-1-daniel@zonque.org> <20191209183511.3576038-12-daniel@zonque.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AkbCVLjbJ9qUtAXD" Content-Disposition: inline In-Reply-To: <20191209183511.3576038-12-daniel@zonque.org> X-Cookie: Backed up the system lately? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AkbCVLjbJ9qUtAXD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 09, 2019 at 07:35:11PM +0100, Daniel Mack wrote: > + /* > + * Setting clock inversion is only supported globally for both DAIs, > + * so we ignore the settings made for DAI1 here. > + */ > + if (index == 0) { > + switch (format & SND_SOC_DAIFMT_INV_MASK) { > + case SND_SOC_DAIFMT_NB_NF: I dunno if it's a blocker but it'd feel nicer to try to verify that the settings are the same and warn if not. > +static int ad242x_set_dai_fmt_dai0(struct snd_soc_dai *codec_dai, > + unsigned int format) > +{ > + return ad242x_set_dai_fmt(codec_dai, format, 0); > +} > + > +static int ad242x_set_dai_fmt_dai1(struct snd_soc_dai *codec_dai, > + unsigned int format) > +{ > + return ad242x_set_dai_fmt(codec_dai, format, 1); > +} You don't need separate ops, just look at dai->id. > +module_platform_driver(ad242x_platform_driver); > + > +MODULE_AUTHOR("Daniel Mack "); > +MODULE_DESCRIPTION("AD242X ALSA SoC driver"); > +MODULE_LICENSE("GPL"); Should have a MODULE_ALIAS() as well for autoloading. --AkbCVLjbJ9qUtAXD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl33k1AACgkQJNaLcl1U h9CJzAf5AVSyR1/mSM1ETDWuCIYuCIEFlu7/ooDTySWL/oz8g/+17UrUPo4t74Kv vEBYnAiDtdNss2zAjSK4TGyvVRqIH+PRdOpEyJcaGK23yLD8tr/MzD3iYvVxXnhP 4rd555BKIjpXedGoFoVUMsqYq6elyLawB42m2kVesOxlY2YxGw76dpcNJH061vjM M8YttjOvZdbN4maecBVI6tq1gTttZ+ap+k/T3CqAEa6A701pg6GlQR0ZX/rsKl84 BTYGk9C2XDYoJrwMp6cPRr93AyxAf/pAzYqhju0Co1VxnvnDxk0r6gfSW4EYn18n kIHoPy2cHMeADFhK7n4j0Sc1c79h4g== =eeff -----END PGP SIGNATURE----- --AkbCVLjbJ9qUtAXD--