From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA48C43603 for ; Mon, 16 Dec 2019 14:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89B872067C for ; Mon, 16 Dec 2019 14:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbfLPOna (ORCPT ); Mon, 16 Dec 2019 09:43:30 -0500 Received: from mga17.intel.com ([192.55.52.151]:22717 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728014AbfLPOn3 (ORCPT ); Mon, 16 Dec 2019 09:43:29 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 06:43:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,322,1571727600"; d="scan'208";a="217187099" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 16 Dec 2019 06:43:25 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 16 Dec 2019 16:43:24 +0200 Date: Mon, 16 Dec 2019 16:43:24 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Paul Cercueil Cc: Sam Ravnborg , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770 Message-ID: <20191216144324.GW1208@intel.com> References: <20191210144142.33143-1-paul@crapouillou.net> <20191214105418.GA5687@ravnborg.org> <20191216131529.GN1208@intel.com> <1576503593.3.2@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1576503593.3.2@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2019 at 02:39:53PM +0100, Paul Cercueil wrote: > Hi Ville, > > > Le lun., déc. 16, 2019 at 15:15, Ville Syrjälä > a écrit : > > On Sat, Dec 14, 2019 at 11:54:18AM +0100, Sam Ravnborg wrote: > >> Hi Paul. > >> > >> On Tue, Dec 10, 2019 at 03:41:37PM +0100, Paul Cercueil wrote: > >> > Add a compatible string for the LCD controller found in the > >> JZ4770 SoC. > >> > > >> > v2: No change > >> > > >> > Signed-off-by: Paul Cercueil > >> > Acked-by: Rob Herring > >> > >> Whole series looks good. > >> Acked-by: Sam Ravnborg > > > > Paul, looks like you forgot to git commit --amend after adding the > > tags. > > Now the commit messages have and extra "# *** extracted tags ***" in > > them. > > Sorry, I'm still relatively new to this :( > > I thought they were going to be automatically removed since they are > comments. They will be of you commit --amend. But not without that. People tend to typo these things quite often so I made dim extract-tags rather liberal in what it accepts. And sometimes that means it'll pull in all kinds of crap when people put a ':' in the wrong place. And that's the reason I added the extra marker so it's trivial to see what got pulled in by dim and what was there already. But it does mean you always have to do the --amend to get rid of the markers. I guess there are at least two options to improve the situation: a) make dim extract-tags more strict and risk missing typoed tags b) make dim push check that there marker has been removed from the commit msg -- Ville Syrjälä Intel