From: Daniel Borkmann <daniel@iogearbox.net>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: bokun.feng@gmail.com, ast@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] kernel: bpf: add releases() annotation
Date: Mon, 16 Dec 2019 16:04:19 +0100 [thread overview]
Message-ID: <20191216150419.GB27202@linux.fritz.box> (raw)
In-Reply-To: <20191216124239.19180-1-jbi.octave@gmail.com>
On Mon, Dec 16, 2019 at 12:42:39PM +0000, Jules Irenge wrote:
> Add sparse annotation to remove issue detected by sparse tool.
> warning: context imbalance in __bpf_prog_exit - unexpected unlock
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> kernel/bpf/trampoline.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c
> index 7e89f1f49d77..fb43b7a57e38 100644
> --- a/kernel/bpf/trampoline.c
> +++ b/kernel/bpf/trampoline.c
> @@ -213,6 +213,7 @@ u64 notrace __bpf_prog_enter(void)
> }
>
> void notrace __bpf_prog_exit(struct bpf_prog *prog, u64 start)
> + __releases(RCU)
Hmm, why are you not adding an annotation to __bpf_prog_enter() as well ?
> {
> struct bpf_prog_stats *stats;
>
> --
> 2.23.0
>
prev parent reply other threads:[~2019-12-16 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:42 [RESEND PATCH] kernel: bpf: add releases() annotation Jules Irenge
2019-12-16 15:04 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216150419.GB27202@linux.fritz.box \
--to=daniel@iogearbox.net \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bokun.feng@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jbi.octave@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).