From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08485C43603 for ; Mon, 16 Dec 2019 18:40:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5697206A5 for ; Mon, 16 Dec 2019 18:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521630; bh=9cbr/GasuS7QSyHWgJSVGLmTNURye9a+SzXMS0zRzyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ik4lCCILlrnYuW62doaInW/XfjvUfXpCyg8S+YBXFRlpxUIzTnFHbG7w/r3ZPkX5p xtm7WdVTZIwjnzHsRFQ6k76Wrd0XjQAfbT8hLV6ybTyTW7ROLH/NwCSXtkl2M+G5tP rEWyL6MWqa+skkPnvvCXVGxRDt5WpZrFE44INkfE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729610AbfLPSk3 (ORCPT ); Mon, 16 Dec 2019 13:40:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:38188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728890AbfLPSCV (ORCPT ); Mon, 16 Dec 2019 13:02:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F3FF207FF; Mon, 16 Dec 2019 18:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519340; bh=9cbr/GasuS7QSyHWgJSVGLmTNURye9a+SzXMS0zRzyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8196N4jLkAfQqOdFRBDOWMlwftUHpBWbKjR+RDjrPEjlHCGenvbEmLaEVL0vgroz DrMC1ycJRtlcbvaD750JN0KYQjVQDueNELzmHZRPzUmXozDnGNzpRzslJTvVua6XlX wOh5kotqWcztgg9eNkVnvyqqAQXmo1T/Ag7PkuaQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.19 009/140] staging: rtl8188eu: fix interface sanity check Date: Mon, 16 Dec 2019 18:47:57 +0100 Message-Id: <20191216174751.178111701@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174747.111154704@linuxfoundation.org> References: <20191216174747.111154704@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 74ca34118a0e05793935d804ccffcedd6eb56596 upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: c2478d39076b ("staging: r8188eu: Add files for new driver - part 20") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191210114751.5119-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -70,7 +70,7 @@ static struct dvobj_priv *usb_dvobj_init phost_conf = pusbd->actconfig; pconf_desc = &phost_conf->desc; - phost_iface = &usb_intf->altsetting[0]; + phost_iface = usb_intf->cur_altsetting; piface_desc = &phost_iface->desc; pdvobjpriv->NumInterfaces = pconf_desc->bNumInterfaces;