From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03160C2D0C3 for ; Mon, 16 Dec 2019 18:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEBF42176D for ; Mon, 16 Dec 2019 18:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521606; bh=RDDDlaYGN4LXkxzUGGrHx9donJGj26ia5jz00kc+6/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WJZDonFfcvL3sg2A+u4uVCmMwN7CUiSlNbg1S1NaSabUa2XvBfKBuRjrNTKPnHILD hMdHl2ocL80dZ1HOJAA6qqCOHtn7sPDJXktExdD8PaxYH/uavLCmmVzJbqKOfvyc1U Ti7TiNFM4pZYk8NoH8Py1f9NQyVRq/34BWK12Nn0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729629AbfLPSkF (ORCPT ); Mon, 16 Dec 2019 13:40:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:38868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbfLPSCn (ORCPT ); Mon, 16 Dec 2019 13:02:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4513B207FF; Mon, 16 Dec 2019 18:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519362; bh=RDDDlaYGN4LXkxzUGGrHx9donJGj26ia5jz00kc+6/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hVQZdqvyrMjddKVjuypgl17aS0byoYxA6Ta8k8sFGqnI8a9Yz1nFcdt+Qj0ukCvD7 SJfCiw50P2m9WB1y+iRcBNXLiehN9laiwTsyLu6QrTo078E8hE/6e4UPbLb6xricaJ nfnBT4fRbmD1bm5Qs0hbe973Wvdzgu9+bAxzCwF0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Machek , Yoshihiro Shimoda , Geert Uytterhoeven , Kishon Vijay Abraham I Subject: [PATCH 4.19 035/140] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role" Date: Mon, 16 Dec 2019 18:48:23 +0100 Message-Id: <20191216174758.620659251@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174747.111154704@linuxfoundation.org> References: <20191216174747.111154704@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yoshihiro Shimoda commit 4bd5ead82d4b877ebe41daf95f28cda53205b039 upstream. Since the role_store() uses strncmp(), it's possible to refer out-of-memory if the sysfs data size is smaller than strlen("host"). This patch fixes it by using sysfs_streq() instead of strncmp(). Reported-by: Pavel Machek Fixes: 9bb86777fb71 ("phy: rcar-gen3-usb2: add sysfs for usb role swap") Cc: # v4.10+ Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-by: Pavel Machek Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Greg Kroah-Hartman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -241,9 +242,9 @@ static ssize_t role_store(struct device if (!ch->has_otg_pins || !ch->phy->init_count) return -EIO; - if (!strncmp(buf, "host", strlen("host"))) + if (sysfs_streq(buf, "host")) new_mode = PHY_MODE_USB_HOST; - else if (!strncmp(buf, "peripheral", strlen("peripheral"))) + else if (sysfs_streq(buf, "peripheral")) new_mode = PHY_MODE_USB_DEVICE; else return -EINVAL;