From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C79C43603 for ; Mon, 16 Dec 2019 18:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B351E2082E for ; Mon, 16 Dec 2019 18:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521557; bh=tlchDs7TvajlhgCZ7OeyLriVnH9A9S73sL+PYnPpnpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GsMHrpon+TpvxKJlFbbqzrKDrxwyAXH8FshcPWwmDgxO1S1TDjTezdfJAMjC7Cdna +rZ6hX95P95vrKMFoMY4emaHXfW0chJw65r3pNou+zf05Rk+cPQy/V8x2w19mGRz0V PCPvkvULb8gqeFmX57dC+XpcZ57zuQ+jNrr29YRo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729559AbfLPSDs (ORCPT ); Mon, 16 Dec 2019 13:03:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:40688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729002AbfLPSDo (ORCPT ); Mon, 16 Dec 2019 13:03:44 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F74420733; Mon, 16 Dec 2019 18:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519423; bh=tlchDs7TvajlhgCZ7OeyLriVnH9A9S73sL+PYnPpnpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vAMv2jDbUj1odzOlcHBV+KuxcFyexbx9TndyfKmgdbZcdVY0w2lua7b+KWSfaKFHH oLIDhfXHOT8Dg/rNiZB8a1/qSQdGuDwxTvj648sCvdixq8l+a3HoIwRXwY9VK8ZdDp XjjQ1RdaCMrH0JImOqefuwYDRomNvpXBeYkG9YoA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pontus Fuchs , Kalle Valo , "David S. Miller" , David Laight , Denis Efremov Subject: [PATCH 4.19 061/140] ar5523: check NULL before memcpy() in ar5523_cmd() Date: Mon, 16 Dec 2019 18:48:49 +0100 Message-Id: <20191216174804.559449657@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174747.111154704@linuxfoundation.org> References: <20191216174747.111154704@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Efremov commit 315cee426f87658a6799815845788fde965ddaad upstream. memcpy() call with "idata == NULL && ilen == 0" results in undefined behavior in ar5523_cmd(). For example, NULL is passed in callchain "ar5523_stat_work() -> ar5523_cmd_write() -> ar5523_cmd()". This patch adds ilen check before memcpy() call in ar5523_cmd() to prevent an undefined behavior. Cc: Pontus Fuchs Cc: Kalle Valo Cc: "David S. Miller" Cc: David Laight Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ar5523/ar5523.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ar5523/ar5523.c +++ b/drivers/net/wireless/ath/ar5523/ar5523.c @@ -255,7 +255,8 @@ static int ar5523_cmd(struct ar5523 *ar, if (flags & AR5523_CMD_FLAG_MAGIC) hdr->magic = cpu_to_be32(1 << 24); - memcpy(hdr + 1, idata, ilen); + if (ilen) + memcpy(hdr + 1, idata, ilen); cmd->odata = odata; cmd->olen = olen;