From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89902C2D0CD for ; Mon, 16 Dec 2019 18:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56A2B20665 for ; Mon, 16 Dec 2019 18:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576522239; bh=iQ82Z0XPD8VLsRDNb2zEoDLlnNPuhQPAuwI+MEFLuKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PFbWOR6vTx0hVgcf2riKA6yRLzvGaQ5LfnEcXd5ySqYK5KgEeQ6OHMvQUTrAk0QRe 1BBi8oiEXN9fUSfX/3PoTWPnGazdYp2X1kllwx3T+iNWi0UpBrazbHmUbnDir4hhZj uBaofkRpQU8B7CpIM7TPqifHHTnaPHEpfoUtQCN8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbfLPRva (ORCPT ); Mon, 16 Dec 2019 12:51:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:41404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbfLPRvZ (ORCPT ); Mon, 16 Dec 2019 12:51:25 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D973F206EC; Mon, 16 Dec 2019 17:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518685; bh=iQ82Z0XPD8VLsRDNb2zEoDLlnNPuhQPAuwI+MEFLuKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uOvy07FuK/tK6C5X3O42OU6nj9JQl3kmDI4DdjUFiQnB47+jxfbXi17/r5yHHKIsD Gw79P4BJfTLxyACOdfT2LgqzqIv99GiBBrhmSEp8WFc/wL8AEmIyc+7MuZmVk2GkpU fBFsUE2/DIWLB5lRgOvu43EdKHa7dmuEKz+BQSq0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , Sasha Levin Subject: [PATCH 4.14 009/267] autofs: fix a leak in autofs_expire_indirect() Date: Mon, 16 Dec 2019 18:45:35 +0100 Message-Id: <20191216174849.872997927@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro [ Upstream commit 03ad0d703df75c43f78bd72e16124b5b94a95188 ] if the second call of should_expire() in there ends up grabbing and returning a new reference to dentry, we need to drop it before continuing. Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/autofs4/expire.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index 141f9bc213a3d..94a0017c923b1 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c @@ -472,9 +472,10 @@ struct dentry *autofs4_expire_indirect(struct super_block *sb, */ flags &= ~AUTOFS_EXP_LEAVES; found = should_expire(expired, mnt, timeout, how); - if (!found || found != expired) - /* Something has changed, continue */ + if (found != expired) { // something has changed, continue + dput(found); goto next; + } if (expired != dentry) dput(dentry); -- 2.20.1