From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A87C43603 for ; Mon, 16 Dec 2019 18:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C0BC20665 for ; Mon, 16 Dec 2019 18:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576522187; bh=jDfD+CL5wDqvqEFQmPaEED4yz67Luv316LwnHkstN0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=T2mIKLSYoqR5mK2CgquW5w5DETS+TZyp1maYLsDPE+iqmcUACxoJ6SIjQWIrOdyHd E+8uMFRUpQx7tLY80h+IY5uiSZGHcXiFhp0uyrvyBEvZvPJBhlQ9S9R9BEfduD6xII K7AMi4Z3USV83XumYBmPovDxhZC37DtUZhrnIH9o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727497AbfLPRwb (ORCPT ); Mon, 16 Dec 2019 12:52:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:44068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfLPRwY (ORCPT ); Mon, 16 Dec 2019 12:52:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3590F20733; Mon, 16 Dec 2019 17:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518743; bh=jDfD+CL5wDqvqEFQmPaEED4yz67Luv316LwnHkstN0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fS/BchNahk2mY7UeIzaUl9PwHDr9hG3A0sd61a2NlQ+rEzczZunqRSG9dnl+iOhGW yyB/M4RrsnjH+y1vtffNudZJV271hA12UeIKh7hG1iZ8ymJ2JQlourI7lkp+tTjl18 cahiVOVjKpwS/rJKzghkz8mPa9jx76XvTMVL51aU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Wolfram Sang , Sasha Levin Subject: [PATCH 4.14 021/267] i2c: core: fix use after free in of_i2c_notify Date: Mon, 16 Dec 2019 18:45:47 +0100 Message-Id: <20191216174851.301369225@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit a4c2fec16f5e6a5fee4865e6e0e91e2bc2d10f37 ] We can't use "adap->dev" after it has been freed. Fixes: 5bf4fa7daea6 ("i2c: break out OF support into separate file") Signed-off-by: Wen Yang Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/i2c-core-of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c index 8d474bb1dc157..17d727e0b8424 100644 --- a/drivers/i2c/i2c-core-of.c +++ b/drivers/i2c/i2c-core-of.c @@ -238,14 +238,14 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, } client = of_i2c_register_device(adap, rd->dn); - put_device(&adap->dev); - if (IS_ERR(client)) { dev_err(&adap->dev, "failed to create client for '%pOF'\n", rd->dn); + put_device(&adap->dev); of_node_clear_flag(rd->dn, OF_POPULATED); return notifier_from_errno(PTR_ERR(client)); } + put_device(&adap->dev); break; case OF_RECONFIG_CHANGE_REMOVE: /* already depopulated? */ -- 2.20.1