From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB32C43603 for ; Mon, 16 Dec 2019 17:52:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53F95206D3 for ; Mon, 16 Dec 2019 17:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518759; bh=hps69Q6C6MR2HFsUkhbANDIaSAymGxUcBs/tQ6ONvhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Aj+acVV0rMNxSYtUhNv4CDp1J7+U0USp6CaVSoKVAIdGixzroQTQbxz9Id4pLKWFr EQVRIu3hSzKRFDMVpPcNUmfZxhStmvNAWab3zu/mogr45rphy9u6hcKsv2TuzV0ZKb aybUlOuPtjSaWvg4Re8k5Y9DR1ZTvhROyIhUTblg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727541AbfLPRwi (ORCPT ); Mon, 16 Dec 2019 12:52:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:44650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727522AbfLPRwg (ORCPT ); Mon, 16 Dec 2019 12:52:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F3752166E; Mon, 16 Dec 2019 17:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576518755; bh=hps69Q6C6MR2HFsUkhbANDIaSAymGxUcBs/tQ6ONvhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h50/8cdz5GZDMSoXg4MU8iKN2j8habWJ6L4eSES8fyjnGchuCPnE20X4pYzQwoKQa HqVl8Z2H+tMwVnyfnyRW+yTXpmTrxoIVMth61cqBKgSdXmTxdJ4TddvCZ7HJySQW5n 1tN/xU8arJBy5Lwl9mVIWU0my4dtJWBTr2+GiChQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ursula Braun , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 052/267] net/smc: use after free fix in smc_wr_tx_put_slot() Date: Mon, 16 Dec 2019 18:46:18 +0100 Message-Id: <20191216174854.223332850@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ursula Braun [ Upstream commit e438bae43c1e08e688c09c410407b59fc1c173b4 ] In smc_wr_tx_put_slot() field pend->idx is used after being cleared. That means always idx 0 is cleared in the wr_tx_mask. This results in a broken administration of available WR send payload buffers. Signed-off-by: Ursula Braun Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/smc/smc_wr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/smc/smc_wr.c b/net/smc/smc_wr.c index de4537f66832a..ed6736a1a112e 100644 --- a/net/smc/smc_wr.c +++ b/net/smc/smc_wr.c @@ -223,12 +223,14 @@ int smc_wr_tx_put_slot(struct smc_link *link, pend = container_of(wr_pend_priv, struct smc_wr_tx_pend, priv); if (pend->idx < link->wr_tx_cnt) { + u32 idx = pend->idx; + /* clear the full struct smc_wr_tx_pend including .priv */ memset(&link->wr_tx_pends[pend->idx], 0, sizeof(link->wr_tx_pends[pend->idx])); memset(&link->wr_tx_bufs[pend->idx], 0, sizeof(link->wr_tx_bufs[pend->idx])); - test_and_clear_bit(pend->idx, link->wr_tx_mask); + test_and_clear_bit(idx, link->wr_tx_mask); return 1; } -- 2.20.1