From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6ED9C43603 for ; Mon, 16 Dec 2019 17:58:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98D70218AC for ; Mon, 16 Dec 2019 17:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519084; bh=aIcXJ6YY5YCUHBkqLx2UXxkVTjCadninB9hTVsHjFvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1kCWG7ayuxDdjTxV3x4UDX3LhYZD3WCO3SFpMmLUcCx8Dl6oaV3acAHVGVckpwKDp yzEJSN0GRHFvIwMYj4SJoOIUGv6FLICShJUXnFI+DwNM36T9I3ivSMYY0dgGqBnq78 I8Yiw8piZuo9JnfUMz2O9EjExxGpXwRk2ZVr7ws0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728213AbfLPR6D (ORCPT ); Mon, 16 Dec 2019 12:58:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:57426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbfLPR6B (ORCPT ); Mon, 16 Dec 2019 12:58:01 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D858206B7; Mon, 16 Dec 2019 17:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519080; bh=aIcXJ6YY5YCUHBkqLx2UXxkVTjCadninB9hTVsHjFvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jK33hRo6IUtaENt3Mxy3oe19V5dp7REtkgztCTCNf/N5Yk8xYNNM9YZGLIeOkaOPb Ls4OI4X3sBHOOTLrsx7sZU6PMzXDMwPQ6i04nIhtw5E7OjDtjsT+3yWzwZWcPB3aFu zzXCfZLmg1RAPpEI3RokcQS8/LnkHiqbFmvA6E4k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Herbert Xu Subject: [PATCH 4.14 147/267] crypto: user - fix memory leak in crypto_report Date: Mon, 16 Dec 2019 18:47:53 +0100 Message-Id: <20191216174910.527101748@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit ffdde5932042600c6807d46c1550b28b0db6a3bc upstream. In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails. Fixes: a38f7907b926 ("crypto: Add userspace configuration API") Cc: Signed-off-by: Navid Emamdoost Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/crypto_user.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c @@ -288,8 +288,10 @@ static int crypto_report(struct sk_buff drop_alg: crypto_mod_put(alg); - if (err) + if (err) { + kfree_skb(skb); return err; + } return nlmsg_unicast(crypto_nlsk, skb, NETLINK_CB(in_skb).portid); }