From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F34C43603 for ; Mon, 16 Dec 2019 17:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F4B124685 for ; Mon, 16 Dec 2019 17:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519115; bh=Tq1/5fPlzCnrmjEKJYkJ4HNVUR07SsD7RSrgauShTUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Bj42REV+dR798J+buGQA17hltIQtuNFX0kYs6UBc2/6zmuG0m7XWbB66aXy9eNKLO EFQqqT2XKrDyYUXYL2+KpY/Fv+Ljs7djcWPk/5lBAIsPvm2VI3GRUf2Wyl1d0I2NQI JImCCwkJ/bGlWHiUUWI3XX9X8SAFCHBSyjrdo6Ts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727783AbfLPR6e (ORCPT ); Mon, 16 Dec 2019 12:58:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:58102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728606AbfLPR6X (ORCPT ); Mon, 16 Dec 2019 12:58:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6CE18205ED; Mon, 16 Dec 2019 17:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519102; bh=Tq1/5fPlzCnrmjEKJYkJ4HNVUR07SsD7RSrgauShTUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R1ufLlsv7RhR2HgtLtjB6zlezgFCtsGdgm9ZHFYdV/Z8EP1VWZTMmKyOicXPxbOnH yURQL4AkyfCxWHlSqScGh4UF3899cvno8QYjlKSWIrBe7F2jC6yIW7lGw8qbeQLmID E9ARtUjygzi8Vhy3lnaiOG+aao77kN9Bm0QzChRk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Song Liu , Sasha Levin Subject: [PATCH 4.14 197/267] md/raid0: Fix an error message in raid0_make_request() Date: Mon, 16 Dec 2019 18:48:43 +0100 Message-Id: <20191216174913.320713854@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit e3fc3f3d0943b126f76b8533960e4168412d9e5a ] The first argument to WARN() is supposed to be a condition. The original code will just print the mdname() instead of the full warning message. Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.") Signed-off-by: Dan Carpenter Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/raid0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c index 449c4dd060fcd..204adde004a3c 100644 --- a/drivers/md/raid0.c +++ b/drivers/md/raid0.c @@ -616,7 +616,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio) tmp_dev = map_sector(mddev, zone, sector, §or); break; default: - WARN("md/raid0:%s: Invalid layout\n", mdname(mddev)); + WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev)); bio_io_error(bio); return true; } -- 2.20.1