From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Andrew F . Davis" <afd@ti.com>,
Andreas Kemnade <andreas@kemnade.info>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCHv2] w1: omap-hdq: Simplify driver with PM runtime autosuspend
Date: Mon, 16 Dec 2019 16:34:53 -0800 [thread overview]
Message-ID: <20191217003453.GU35479@atomide.com> (raw)
In-Reply-To: <CAHCN7xLYRm3Lstb=-r6hguDOrxwi-dT0nTzkhYM0S5GYtEzckw@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [191216 19:04]:
> On Mon, Dec 16, 2019 at 10:43 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > * Tony Lindgren <tony@atomide.com> [191216 14:54]:
> > > Vignesh, any comments on the ti,mode = "1w" and removal of the call to
> > > hdq_disable_interrupt()? Is there some specific section where we need
> > > to have interrupts disabled and then re-enabled?
> >
> > OK I got "1w" mode working too now. We need to clear the irqstatus before
> > calling wait_event_timeout() on it, and we're now missing it in the
> > hdq_read_byte().
> >
> > Looks like we should not tinker with the actual irstatus register though,
> > that's up to the hdq_isr() to manage.
> >
> > So the following helper is probably what we want to do additionally.
> > I'll be posting v3 of the $subject patch.
>
> I manually attempted to apply the patches. I 'think' I did it right.
>
> For testing, I ran:
> watch cat /sys/devices/w1_bus_master1/01-000000000000/power_supply/bq27000-battery/voltage_now
>
> I inserted and removed the power cable several times and observed the
> voltage readings with the battery connected.
> The numbers looked reasonable.
>
> I then put the board to suspend, waited a few seconds and woke the
> board from sleep. I resumed my 'watch' function from above and it
> worked just fine.
> If there is nothing else you want me to test, go ahead and add:
>
> Tested-by: Adam Ford <aford173@gmail.com> #logicpd-torpedo-37xx-devkit
Thanks for testing, will post v3 shortly with the acks.
Regards,
Tony
prev parent reply other threads:[~2019-12-17 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 14:53 [PATCHv2] w1: omap-hdq: Simplify driver with PM runtime autosuspend Tony Lindgren
2019-12-16 16:43 ` Tony Lindgren
2019-12-16 19:03 ` Adam Ford
2019-12-17 0:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217003453.GU35479@atomide.com \
--to=tony@atomide.com \
--cc=afd@ti.com \
--cc=aford173@gmail.com \
--cc=andreas@kemnade.info \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vigneshr@ti.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).