From: Sargun Dhillon <sargun@sargun.me>
To: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: tycho@tycho.ws, jannh@google.com, cyphar@cyphar.com,
christian.brauner@ubuntu.com, oleg@redhat.com,
luto@amacapital.net, viro@zeniv.linux.org.uk,
gpascutto@mozilla.com, ealvarez@mozilla.com, fweimer@redhat.com,
jld@mozilla.com
Subject: [PATCH v3 0/4] Add pidfd getfd ioctl (Was Add ptrace get_fd request)
Date: Tue, 17 Dec 2019 00:58:45 +0000 [thread overview]
Message-ID: <20191217005842.GA14379@ircssh-2.c.rugged-nimbus-611.internal> (raw)
This patchset introduces a mechanism to capture file descriptors from other
processes by pidfd and ioctl. Although this can be achieved using
SCM_RIGHTS, and parasitic code injection, this offers a more
straightforward mechanism.
It has a flags mechanism that's only usable to set CLOEXEC on the fd,
but I'm thinking that it could be extended to other aspects. For example,
for sockets, one could want to scrub the cgroup information.
Changes since v2:
* Move to ioctl on pidfd instead of ptrace function
* Add security check before moving file descriptor
Changes since the RFC v1:
* Introduce a new helper to fs/file.c to fetch a file descriptor from
any process. It largely uses the code suggested by Oleg, with a few
changes to fix locking
* It uses an extensible options struct to supply the FD, and option.
* I added a sample, using the code from the user-ptrace sample
Sargun Dhillon (4):
vfs, fdtable: Add get_task_file helper
pid: Add PIDFD_IOCTL_GETFD to fetch file descriptors from processes
samples: split generalized user-trap code into helper file
samples: Add example of using pidfd getfd in conjunction with user
trap
Documentation/ioctl/ioctl-number.rst | 1 +
fs/file.c | 22 +++-
include/linux/file.h | 2 +
include/linux/pid.h | 1 +
include/uapi/linux/pid.h | 26 ++++
kernel/fork.c | 72 ++++++++++
samples/seccomp/.gitignore | 1 +
samples/seccomp/Makefile | 15 ++-
samples/seccomp/user-trap-helper.c | 84 ++++++++++++
samples/seccomp/user-trap-helper.h | 13 ++
samples/seccomp/user-trap-pidfd.c | 190 +++++++++++++++++++++++++++
samples/seccomp/user-trap.c | 85 +-----------
12 files changed, 424 insertions(+), 88 deletions(-)
create mode 100644 include/uapi/linux/pid.h
create mode 100644 samples/seccomp/user-trap-helper.c
create mode 100644 samples/seccomp/user-trap-helper.h
create mode 100644 samples/seccomp/user-trap-pidfd.c
--
2.20.1
next reply other threads:[~2019-12-17 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 0:58 Sargun Dhillon [this message]
2019-12-17 3:02 ` [PATCH v3 0/4] Add pidfd getfd ioctl (Was Add ptrace get_fd request) Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217005842.GA14379@ircssh-2.c.rugged-nimbus-611.internal \
--to=sargun@sargun.me \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=cyphar@cyphar.com \
--cc=ealvarez@mozilla.com \
--cc=fweimer@redhat.com \
--cc=gpascutto@mozilla.com \
--cc=jannh@google.com \
--cc=jld@mozilla.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).