* [PATCH 1/2] kconfig: localmodconfig: remove unused $config
@ 2019-12-17 4:16 Masahiro Yamada
2019-12-17 4:16 ` [PATCH 2/2] kconfig: localmodconfig: fix indentation for closing brace Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-12-17 4:16 UTC (permalink / raw)
To: linux-kbuild; +Cc: Steven Rostedt, Masahiro Yamada, linux-kernel
This is unused since commit cdfc47950a53 ("kconfig: search for a config
to base the local(mod|yes)config on").
Having unused $config is confusing because $config is used as a local
variable in various sub-routines.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/streamline_config.pl | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 08d76d7b3b81..bbaa1e11a4e9 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -56,8 +56,6 @@ sub dprint {
print STDERR @_;
}
-my $config = ".config";
-
my $uname = `uname -r`;
chomp $uname;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] kconfig: localmodconfig: fix indentation for closing brace
2019-12-17 4:16 [PATCH 1/2] kconfig: localmodconfig: remove unused $config Masahiro Yamada
@ 2019-12-17 4:16 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2019-12-17 4:16 UTC (permalink / raw)
To: linux-kbuild; +Cc: Steven Rostedt, Masahiro Yamada, linux-kernel
This is the closing brace for the foreach loop. Fix the misleading
indentation.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/kconfig/streamline_config.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index bbaa1e11a4e9..e2f8504f5a2d 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -372,7 +372,7 @@ if (defined($lsmod_file)) {
$lsmod = "$dir/lsmod";
last;
}
-}
+ }
if (!defined($lsmod)) {
# try just the path
$lsmod = "lsmod";
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-17 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 4:16 [PATCH 1/2] kconfig: localmodconfig: remove unused $config Masahiro Yamada
2019-12-17 4:16 ` [PATCH 2/2] kconfig: localmodconfig: fix indentation for closing brace Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).