From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>,
akpm@linux-foundation.org, alan.maguire@oracle.com,
anton.ivanov@cambridgegreys.com, arnd@arndb.de,
davidgow@google.com, jdike@addtoit.com, keescook@chromium.org,
richard@nod.at, rppt@linux.ibm.com, skhan@linuxfoundation.org,
yzaikin@google.com
Cc: gregkh@linuxfoundation.org, logang@deltatee.com,
mcgrof@kernel.org, knut.omang@oracle.com,
linux-um@lists.infradead.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [RFC v1 3/6] kunit: test: create a single centralized executor for all tests
Date: Tue, 17 Dec 2019 00:04:07 -0800 [thread overview]
Message-ID: <20191217080408.0E805207FF@mail.kernel.org> (raw)
In-Reply-To: <20191216220555.245089-4-brendanhiggins@google.com>
Quoting Brendan Higgins (2019-12-16 14:05:52)
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index dba48304b3bd3..c070798ebb765 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -217,11 +217,8 @@ int kunit_run_tests(struct kunit_suite *suite);
> * everything else is definitely initialized.
> */
> #define kunit_test_suite(suite) \
> - static int kunit_suite_init##suite(void) \
Oh this should have been __init before.
> - { \
> - return kunit_run_tests(&suite); \
> - } \
> - late_initcall(kunit_suite_init##suite)
> + static struct kunit_suite *__kunit_suite_##suite \
> + __used __aligned(8) __section(.kunit_test_suites) = &suite
>
> /*
> * Like kunit_alloc_resource() below, but returns the struct kunit_resource
> diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
> new file mode 100644
> index 0000000000000..978086cfd257d
> --- /dev/null
> +++ b/lib/kunit/executor.c
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Base unit test (KUnit) API.
> + *
> + * Copyright (C) 2019, Google LLC.
> + * Author: Brendan Higgins <brendanhiggins@google.com>
> + */
> +
> +#include <linux/init.h>
> +#include <linux/printk.h>
> +#include <kunit/test.h>
> +
> +/*
> + * These symbols point to the .kunit_test_suites section and are defined in
> + * include/asm-generic/vmlinux.lds.h, and consequently must be extern.
> + */
> +extern struct kunit_suite *__kunit_suites_start[];
> +extern struct kunit_suite *__kunit_suites_end[];
> +
> +static bool kunit_run_all_tests(void)
Should be __init?
> +{
> + struct kunit_suite **suite;
Can this be const? And the linker references above too?
> + bool has_test_failed = false;
> +
> + for (suite = __kunit_suites_start;
> + suite < __kunit_suites_end;
> + ++suite) {
> + if (kunit_run_tests(*suite))
> + has_test_failed = true;
> + }
> +
> + return !has_test_failed;
> +}
> +
> +static int kunit_executor_init(void)
Should be __init?
> +{
> + if (kunit_run_all_tests())
> + return 0;
> + else
> + return -EFAULT;
Why two functions instead of just one that is the target of the
late_initcall? Nitpick: deindent that last return and take it out of the
else.
> +}
> +
> +late_initcall(kunit_executor_init);
next prev parent reply other threads:[~2019-12-17 8:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 22:05 [RFC v1 0/6] kunit: create a centralized executor to dispatch all KUnit tests Brendan Higgins
2019-12-16 22:05 ` [RFC v1 1/6] vmlinux.lds.h: add linker section for KUnit test suites Brendan Higgins
2019-12-17 8:21 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 2/6] arch: um: " Brendan Higgins
2019-12-17 8:21 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 3/6] kunit: test: create a single centralized executor for all tests Brendan Higgins
2019-12-17 8:04 ` Stephen Boyd [this message]
2020-01-23 22:54 ` Brendan Higgins
2019-12-16 22:05 ` [RFC v1 4/6] init: main: add KUnit to kernel init Brendan Higgins
2019-12-17 7:58 ` Stephen Boyd
2020-01-23 22:45 ` Brendan Higgins
2019-12-16 22:05 ` [RFC v1 5/6] kunit: test: add test plan to KUnit TAP format Brendan Higgins
2019-12-17 8:18 ` Stephen Boyd
2019-12-16 22:05 ` [RFC v1 6/6] kunit: Add 'kunit_shutdown' option Brendan Higgins
2019-12-17 8:06 ` Stephen Boyd
2020-01-23 22:56 ` Brendan Higgins
2020-01-06 22:40 ` [RFC v1 0/6] kunit: create a centralized executor to dispatch all KUnit tests Luis Chamberlain
2020-01-23 22:40 ` Brendan Higgins
2020-01-27 17:40 ` Frank Rowand
2020-01-28 7:19 ` Brendan Higgins
2020-01-28 18:36 ` Frank Rowand
2020-01-28 19:35 ` Tim.Bird
2020-01-28 19:53 ` Brendan Higgins
2020-01-29 4:24 ` Frank Rowand
2020-01-29 21:18 ` Brendan Higgins
2020-01-29 13:06 ` Alan Maguire
2020-01-29 21:28 ` Brendan Higgins
2020-03-02 19:45 ` Luis Chamberlain
2020-03-02 19:05 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217080408.0E805207FF@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=keescook@chromium.org \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mcgrof@kernel.org \
--cc=richard@nod.at \
--cc=rppt@linux.ibm.com \
--cc=skhan@linuxfoundation.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).