From: Peter Zijlstra <peterz@infradead.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: boqun.feng@gmail.com, mingo@redhat.com, will@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: locking: add releases(lock) annotation
Date: Tue, 17 Dec 2019 10:13:04 +0100 [thread overview]
Message-ID: <20191217091304.GY2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191216153952.37038-1-jbi.octave@gmail.com>
On Mon, Dec 16, 2019 at 03:39:52PM +0000, Jules Irenge wrote:
> Add releases(lock) annotation to remove issue detected by sparse tool.
> warning: context imbalance in xxxxxxx() - unexpected unlock
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
So, personally I detest these sparse things.
But I'm also confused, as that function already has the annotation, see
spinlock_api_smp.h. In order for sparse to see these annotations at the
usage size, they need to be on the declaration, not the definition.
next prev parent reply other threads:[~2019-12-17 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:39 [PATCH] kernel: locking: add releases(lock) annotation Jules Irenge
2019-12-17 9:13 ` Peter Zijlstra [this message]
2020-02-06 14:59 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217091304.GY2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).