From: Greg KH <gregkh@linuxfoundation.org>
To: Scott Schafer <schaferjscott@gmail.com>
Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com,
Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/23] staging: qlge: Fix WARNING: Missing a blank line after declarations
Date: Tue, 17 Dec 2019 13:37:25 +0100 [thread overview]
Message-ID: <20191217123725.GA3161766@kroah.com> (raw)
In-Reply-To: <815a27ebb89b7a08e616fddbe0583eabd3c4401b.1576086080.git.schaferjscott@gmail.com>
On Wed, Dec 11, 2019 at 12:12:33PM -0600, Scott Schafer wrote:
> Fix WARNING: Missing a blank line after declarations in the following
> files:
> qlge.h
> qlge_dbg.c
> qlge_main.c
> qlge_mpi.c
>
> Signed-off-by: Scott Schafer <schaferjscott@gmail.com>
> ---
> drivers/staging/qlge/qlge.h | 2 +-
> drivers/staging/qlge/qlge_dbg.c | 10 +++++-----
> drivers/staging/qlge/qlge_main.c | 26 +++++++++++++-------------
> drivers/staging/qlge/qlge_mpi.c | 12 ++++++------
> 4 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 89502a8300f6..d45c53a053c2 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2227,7 +2227,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr)
> static inline u32 ql_read_sh_reg(__le32 *addr)
> {
> u32 reg;
> -
> +
The description of this patch is NOT what this patch is doing. It's
fixing up the mess you added in the previous patch :(
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-17 12:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:12 [PATCH v2 00/23] V2: Break up from one patch to multiple Scott Schafer
2019-12-11 18:12 ` [PATCH v2 01/23] staging: qlge: Fix CHECK extra blank lines in many files Scott Schafer
2019-12-11 18:12 ` [PATCH v2 02/23] staging: qlge: Fix CHECK: Alignment should match open parenthesis Scott Schafer
2019-12-11 18:12 ` [PATCH v2 03/23] staging:qlge: Fix WARNING: Missing a blank line after declarations Scott Schafer
2019-12-17 12:36 ` [PATCH v2 03/23] staging: qlge: " Greg KH
2019-12-11 18:12 ` [PATCH v2 04/23] " Scott Schafer
2019-12-17 12:37 ` Greg KH [this message]
2019-12-11 18:12 ` [PATCH v2 05/23] staging: qlge: Fix CHECK: Blank lines aren't necessary before a close brace '}' Scott Schafer
2019-12-11 18:12 ` [PATCH v2 06/23] staging: qlge: Fix CHECK: Blank lines aren't necessary after an open brace '{' Scott Schafer
2019-12-11 18:12 ` [PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines Scott Schafer
2019-12-11 18:12 ` [PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header Scott Schafer
2019-12-11 18:12 ` [PATCH v2 09/23] staging: qlge: Fix CHECK: No space is necessary after a cast Scott Schafer
2019-12-11 18:12 ` [PATCH v2 10/23] staging: qlge: Fix CHECK: blank line after function/struct/union/enum declarations Scott Schafer
2019-12-11 18:12 ` [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement Scott Schafer
2019-12-12 12:12 ` Dan Carpenter
2019-12-12 15:02 ` Scott Schafer
2019-12-12 16:03 ` Greg KH
2019-12-12 16:31 ` Dan Carpenter
2019-12-12 19:25 ` David Miller
2019-12-11 18:12 ` [PATCH v2 12/23] staging: qlge: Fix WARNING: please, no space before tabs in qlge.h Scott Schafer
2019-12-11 18:12 ` [PATCH v2 13/23] staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV) Scott Schafer
2019-12-11 18:12 ` [PATCH v2 14/23] staging: qlge: Fix WARNING: Unnecessary space before function pointer arguments Scott Schafer
2019-12-11 18:12 ` [PATCH v2 15/23] staging: qlge: Fix WARNING: please, no spaces at the start of a line Scott Schafer
2019-12-11 18:12 ` [PATCH v2 16/23] staging: qlge: Fix WARNING: Block comments use a trailing */ on a separate line Scott Schafer
2019-12-11 18:12 ` [PATCH v2 17/23] staging: qlge: Fix WARNING: else is not generally useful after a break or return Scott Schafer
2019-12-11 18:12 ` [PATCH v2 18/23] staging: qlge: Fix CHECK: Prefer using the BIT macro Scott Schafer
2019-12-11 18:12 ` [PATCH v2 19/23] staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20ms Scott Schafer
2019-12-11 18:12 ` [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay Scott Schafer
2019-12-12 10:45 ` Sergei Shtylyov
2019-12-12 11:00 ` Scott Schafer
2019-12-12 11:12 ` Dan Carpenter
2019-12-12 11:07 ` Dan Carpenter
2019-12-11 18:12 ` [PATCH v2 21/23] staging: qlge: Fix WARNING: suspect code indent for conditional statements Scott Schafer
2019-12-11 18:12 ` [PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement Scott Schafer
2019-12-11 18:12 ` [PATCH v2 23/23] staging: qlge: Fix WARNING: Avoid multiple line dereference Scott Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217123725.GA3161766@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=schaferjscott@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).