From: Nathan Chancellor <natechancellor@gmail.com>
To: Ley Foon Tan <lftan@altera.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Andrew Murray <andrew.murray@arm.com>,
rfi@lists.rocketboards.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] PCI: altera: Adjust indentation in altera_pcie_valid_device
Date: Tue, 17 Dec 2019 18:27:52 -0700 [thread overview]
Message-ID: <20191218012752.47054-1-natechancellor@gmail.com> (raw)
Clang warns:
../drivers/pci/controller/pcie-altera.c:196:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
return true;
^
../drivers/pci/controller/pcie-altera.c:193:2: note: previous statement
is here
if (bus->number == pcie->root_bus_nr && dev > 0)
^
1 warning generated.
This warning occurs because there is a space after the tab on this line.
Remove it so that the indentation is consistent with the Linux kernel
coding style and clang no longer warns.
Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/815
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/pci/controller/pcie-altera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
index b447c3e4abad..24cb1c331058 100644
--- a/drivers/pci/controller/pcie-altera.c
+++ b/drivers/pci/controller/pcie-altera.c
@@ -193,7 +193,7 @@ static bool altera_pcie_valid_device(struct altera_pcie *pcie,
if (bus->number == pcie->root_bus_nr && dev > 0)
return false;
- return true;
+ return true;
}
static int tlp_read_packet(struct altera_pcie *pcie, u32 *value)
--
2.24.1
next reply other threads:[~2019-12-18 1:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 1:27 Nathan Chancellor [this message]
2019-12-18 2:30 ` [PATCH] PCI: altera: Adjust indentation in altera_pcie_valid_device Tan, Ley Foon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218012752.47054-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rfi@lists.rocketboards.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).