* [PATCH] scsi: aic7xxx: Adjust indentation in ahc_find_syncrate
@ 2019-12-18 1:42 Nathan Chancellor
2019-12-19 23:52 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2019-12-18 1:42 UTC (permalink / raw)
To: Hannes Reinecke, Martin K. Petersen, James E.J. Bottomley
Cc: linux-scsi, linux-kernel, clang-built-linux, Nathan Chancellor
Clang warns:
../drivers/scsi/aic7xxx/aic7xxx_core.c:2317:5: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
^
../drivers/scsi/aic7xxx/aic7xxx_core.c:2310:4: note: previous statement
is here
if (syncrate == &ahc_syncrates[maxsync])
^
1 warning generated.
This warning occurs because there is a space amongst the tabs on this
line. Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.
This has been a problem since the beginning of git history hence no
fixes tag.
Link: https://github.com/ClangBuiltLinux/linux/issues/817
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/scsi/aic7xxx/aic7xxx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
index a9d40d3b90ef..4190a025381a 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_core.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
@@ -2314,7 +2314,7 @@ ahc_find_syncrate(struct ahc_softc *ahc, u_int *period,
* At some speeds, we only support
* ST transfers.
*/
- if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
+ if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
*ppr_options &= ~MSG_EXT_PPR_DT_REQ;
break;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aic7xxx: Adjust indentation in ahc_find_syncrate
2019-12-18 1:42 [PATCH] scsi: aic7xxx: Adjust indentation in ahc_find_syncrate Nathan Chancellor
@ 2019-12-19 23:52 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-12-19 23:52 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Hannes Reinecke, Martin K. Petersen, James E.J. Bottomley,
linux-scsi, linux-kernel, clang-built-linux
Nathan,
> Clang warns:
>
> ../drivers/scsi/aic7xxx/aic7xxx_core.c:2317:5: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
> if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
> ^
> ../drivers/scsi/aic7xxx/aic7xxx_core.c:2310:4: note: previous statement
Applied to 5.6/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 1:42 [PATCH] scsi: aic7xxx: Adjust indentation in ahc_find_syncrate Nathan Chancellor
2019-12-19 23:52 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).