linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	clang-built-linux@googlegroups.com
Subject: Re: [PATCH] vfs: Adjust indentation in remap_verify_area
Date: Wed, 18 Dec 2019 03:50:55 +0000	[thread overview]
Message-ID: <20191218035055.GG4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20191218032351.5920-1-natechancellor@gmail.com>

On Tue, Dec 17, 2019 at 08:23:51PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> ../fs/read_write.c:1760:3: warning: misleading indentation; statement is
> not part of the previous 'if' [-Wmisleading-indentation]
>          if (unlikely((loff_t) (pos + len) < 0))
>          ^
> ../fs/read_write.c:1757:2: note: previous statement is here
>         if (unlikely(pos < 0 || len < 0))
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel
> coding style and clang no longer warns.
> 
> Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
> Link: https://github.com/ClangBuiltLinux/linux/issues/828
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Egads...  This commit message is way, way over the top.

1) the warning is more obscure than the problem it points to.

2) simple "statement accidentally indented one column too deep"
would do just fine

3) crediting the tool is generally a good idea, but in situation
when the quality of warning is that low you'd be better paraphrasing
it and mentioning the tool that has pointed it out.  No need to quote
the verbiage.

  reply	other threads:[~2019-12-18  3:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  3:23 [PATCH] vfs: Adjust indentation in remap_verify_area Nathan Chancellor
2019-12-18  3:50 ` Al Viro [this message]
2019-12-18  5:16   ` [PATCH v2] " Nathan Chancellor
2019-12-18 11:04     ` David Sterba
2019-12-22  3:16       ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218035055.GG4203@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).