From: Dominik Brodowski <linux@dominikbrodowski.net>
To: youling 257 <youling257@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rafael Wysocki <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr
Date: Wed, 18 Dec 2019 09:03:47 +0100 [thread overview]
Message-ID: <20191218080347.GA324400@light.dominikbrodowski.net> (raw)
In-Reply-To: <CAOzgRda=q0mBeBx_i8N0VT_a_ud8EVcf9hVC5Y_Oz2sdAdGGLg@mail.gmail.com>
On Wed, Dec 18, 2019 at 12:10:08PM +0800, youling 257 wrote:
> only Revert "fs: remove ksys_dup()", not see the warning
> "/system/bin/sh: No controlling tty: open /dev/tty: No such device or
> address."
>
> yes, "fs: remove ksys_dup()" caused my system/bin/sh problem.
>
> but test "early init: fix error handling when opening /dev/console",
> still can see "/system/bin/sh: No controlling tty" warning, it not
> solve my problem.
FWIW, I see a similar (seemingly harmless) warning both _before_ and
after my patches, so I am not sure that this is a real regression.
Thanks,
Dominik
next prev parent reply other threads:[~2019-12-18 8:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 18:14 [GIT PULL] remove ksys_mount() and ksys_dup() Dominik Brodowski
2019-12-12 18:14 ` [PATCH 1/5] devtmpfs: use do_mount() instead of ksys_mount() Dominik Brodowski
2019-12-12 18:14 ` [PATCH 2/5] initrd: " Dominik Brodowski
2019-12-12 18:14 ` [PATCH 3/5] init: " Dominik Brodowski
2019-12-16 9:45 ` Borislav Petkov
2019-12-16 9:51 ` Dominik Brodowski
2019-12-16 10:19 ` Borislav Petkov
2019-12-12 18:14 ` [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr Dominik Brodowski
2019-12-12 18:14 ` [PATCH 5/5] fs: remove ksys_dup() Dominik Brodowski
2019-12-15 19:50 ` [GIT PULL] remove ksys_mount() and ksys_dup() Linus Torvalds
2019-12-15 20:50 ` pr-tracker-bot
[not found] ` <CAJmaN=ksaH5AgRUdVPGWKZzjEinU+goaCqedH1PW6OmKYc_TuA@mail.gmail.com>
2019-12-17 19:37 ` Greg Kroah-Hartman
2019-12-17 20:05 ` Jesse Barnes
2019-12-17 20:40 ` Linus Torvalds
2019-12-17 22:21 ` Jesse Barnes
2019-12-17 22:57 ` Al Viro
2019-12-17 23:23 ` Al Viro
2019-12-18 7:51 ` Dominik Brodowski
2019-12-18 13:37 ` Al Viro
2019-12-17 5:17 ` [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr youling257
2019-12-17 6:42 ` Dominik Brodowski
2019-12-17 9:33 ` youling 257
2019-12-17 21:14 ` Linus Torvalds
2019-12-18 4:10 ` youling 257
2019-12-18 8:03 ` Dominik Brodowski [this message]
2019-12-18 21:50 ` youling 257
2019-12-19 7:08 ` Dominik Brodowski
2019-12-19 9:34 ` youling 257
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218080347.GA324400@light.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).