From: Jan Kara <jack@suse.cz>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] ext2: Adjust indentation in ext2_fill_super
Date: Wed, 18 Dec 2019 09:38:39 +0100 [thread overview]
Message-ID: <20191218083838.GB4083@quack2.suse.cz> (raw)
In-Reply-To: <20191218031930.31393-1-natechancellor@gmail.com>
On Tue 17-12-19 20:19:31, Nathan Chancellor wrote:
> Clang warns:
>
> ../fs/ext2/super.c:1076:3: warning: misleading indentation; statement is
> not part of the previous 'if' [-Wmisleading-indentation]
> sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> ^
> ../fs/ext2/super.c:1074:2: note: previous statement is here
> if (EXT2_BLOCKS_PER_GROUP(sb) == 0)
> ^
> 1 warning generated.
>
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
>
> Fixes: 41f04d852e35 ("[PATCH] ext2: fix mounts at 16T")
> Link: https://github.com/ClangBuiltLinux/linux/issues/827
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Thanks! I've added the patch to my tree.
Honza
> ---
>
> v1 -> v2:
>
> * Adjust link to point to the right issue.
>
> fs/ext2/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 8643f98e9578..4a4ab683250d 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1073,9 +1073,9 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>
> if (EXT2_BLOCKS_PER_GROUP(sb) == 0)
> goto cantfind_ext2;
> - sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> - le32_to_cpu(es->s_first_data_block) - 1)
> - / EXT2_BLOCKS_PER_GROUP(sb)) + 1;
> + sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
> + le32_to_cpu(es->s_first_data_block) - 1)
> + / EXT2_BLOCKS_PER_GROUP(sb)) + 1;
> db_count = (sbi->s_groups_count + EXT2_DESC_PER_BLOCK(sb) - 1) /
> EXT2_DESC_PER_BLOCK(sb);
> sbi->s_group_desc = kmalloc_array (db_count,
> --
> 2.24.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-12-18 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 3:15 [PATCH] ext2: Adjust indentation in ext2_fill_super Nathan Chancellor
2019-12-18 3:19 ` [PATCH v2] " Nathan Chancellor
2019-12-18 8:38 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218083838.GB4083@quack2.suse.cz \
--to=jack@suse.cz \
--cc=clang-built-linux@googlegroups.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).