From: Johan Hovold <johan@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] serdev: fix builds with CONFIG_SERIAL_DEV_BUS=m
Date: Wed, 18 Dec 2019 10:38:06 +0100 [thread overview]
Message-ID: <20191218093806.GK22665@localhost> (raw)
In-Reply-To: <20191218092958.tu6n452zwbpkreks@pengutronix.de>
On Wed, Dec 18, 2019 at 10:29:58AM +0100, Uwe Kleine-König wrote:
> On Wed, Dec 18, 2019 at 10:06:06AM +0100, Johan Hovold wrote:
> > On Wed, Dec 18, 2019 at 09:38:42AM +0100, Uwe Kleine-König wrote:
> > > Commit 54edb425346a ("serdev: simplify Makefile") broke builds with
> > > serdev configured as module. I don't understand it completely yet, but
> > > it seems that
> > >
> > > obj-$(CONFIG_SERIAL_DEV_BUS) += serdev/
> > >
> > > in drivers/tty/Makefile with CONFIG_SERIAL_DEV_BUS=m doesn't result in
> > > code that is added using obj-y in drivers/tty/serdev/Makefile being
> > > compiled. So instead of dropping $(CONFIG_SERIAL_DEV_BUS) in serdev's
> > > Makefile, drop it in drivers/tty/Makefile.
> >
> > Why not simply revert the offending patch? There are some dependencies
> > here related to how the tty layer is built. If you're still not certain
> > on why things broke, I suggest just reverting for now.
>
> I see that it is not easy to define what obj-y should do in a Makefile
> that is included via obj-m. Now it is the other way round and that
> should be safe. This construct is used in several places, so I'd say the
> patch is fine unless you have more concrete concerns.
No, and I don't have time to look into this right now.
It's more about the general principle that a patch should do one thing;
in this case unbreak the build. If you want to do cleanups as well, you
do that separately (and argue for why its needed).
Johan
next prev parent reply other threads:[~2019-12-18 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201912181000.82Z7czbN%lkp@intel.com>
2019-12-18 8:38 ` [PATCH] serdev: fix builds with CONFIG_SERIAL_DEV_BUS=m Uwe Kleine-König
2019-12-18 9:06 ` Johan Hovold
2019-12-18 9:29 ` Uwe Kleine-König
2019-12-18 9:38 ` Johan Hovold [this message]
2019-12-18 10:39 ` Uwe Kleine-König
2019-12-18 12:51 ` Johan Hovold
2019-12-18 17:23 ` kbuild obj-m directory descend (was: Re: [PATCH] serdev: fix builds with CONFIG_SERIAL_DEV_BUS=m) Johan Hovold
2019-12-19 2:00 ` Masahiro Yamada
2019-12-19 8:18 ` Johan Hovold
2019-12-19 8:55 ` Masahiro Yamada
2019-12-19 9:49 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218093806.GK22665@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).