From: Petr Mladek <pmladek@suse.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
sergey.senozhatsky@gmail.com, wangkefeng.wang@huawei.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] tools lib api fs: fix gcc9 compilation error
Date: Wed, 18 Dec 2019 12:36:42 +0100 [thread overview]
Message-ID: <20191218113642.2hw5rx2t6f277b3b@pathway.suse.cz> (raw)
In-Reply-To: <20191211080109.18765-1-andrey.zhizhikin@leica-geosystems.com>
On Wed 2019-12-11 08:01:09, Andrey Zhizhikin wrote:
> GCC9 introduced string hardening mechanisms, which exhibits the error
> during fs api compilation:
>
> error: '__builtin_strncpy' specified bound 4096 equals destination size
> [-Werror=stringop-truncation]
>
> This comes when the length of copy passed to strncpy is is equal to
> destination size, which could potentially lead to buffer overflow.
>
> There is a need to mitigate this potential issue by limiting the size of
> destination by 1 and explicitly terminate the destination with NULL.
>
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2019-12-18 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 8:01 [PATCH] tools lib api fs: fix gcc9 compilation error Andrey Zhizhikin
2019-12-17 21:21 ` Andrey Zhizhikin
2019-12-18 3:10 ` Sergey Senozhatsky
2019-12-18 4:40 ` Sergey Senozhatsky
2019-12-18 7:29 ` Jiri Olsa
2019-12-18 11:36 ` Petr Mladek [this message]
2019-12-18 14:33 ` Arnaldo Carvalho de Melo
2019-12-18 17:03 ` Andrey Zhizhikin
2020-01-10 17:53 ` [tip: perf/core] tools lib api fs: Fix gcc9 stringop-truncation " tip-bot2 for Andrey Zhizhikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218113642.2hw5rx2t6f277b3b@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=acme@redhat.com \
--cc=andrey.z@gmail.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=songliubraving@fb.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).