From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DA7C2D0CD for ; Wed, 18 Dec 2019 16:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88531227BF for ; Wed, 18 Dec 2019 16:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576688357; bh=L22wapzFBIEZL7FfvunmE+UTD7Qk4x5ULjIEpAn7WuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IDf7/Obih3HQ5WANjeP7C861FlTgoHbxzFUNFWJmWr9QC1eyxQlJ/C3fsgPsHJ7ZY DL/Zl4a5cED5ddin/8gmMMDDrifcXa5trSu5i+vWOzvz9nUXAXkJ6HsTa7DGtaTNUR nJRhAABxR1ZY4iwb+H4EnfF84zOxvYeYuntTS6vM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727647AbfLRQ7Q (ORCPT ); Wed, 18 Dec 2019 11:59:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:51770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727192AbfLRQ7Q (ORCPT ); Wed, 18 Dec 2019 11:59:16 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C7E22176D; Wed, 18 Dec 2019 16:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576688355; bh=L22wapzFBIEZL7FfvunmE+UTD7Qk4x5ULjIEpAn7WuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sWNhtArZY2n/ypf1VIbh14nUjXAZD7dn6yor/mDgQOqA5+KZFJJPOmBEwN4vvN6aW cXIb+u5THLQtt5LTAEE5RgohzUSIm4sGE+DnISGusSqekmx/q359qo/YZUrhO8cRuO xQCtL9xhougBueopYUIVAPyZ7XfrOpjCXyv8RPs4= Date: Wed, 18 Dec 2019 16:59:11 +0000 From: Will Deacon To: Laurent Pinchart Cc: Andrey Konovalov , Greg Kroah-Hartman , linux-media@vger.kernel.org, LKML , Andrew Morton , Mauro Carvalho Chehab , Dmitry Vyukov , Kostya Serebryany , stable Subject: Re: [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors Message-ID: <20191218165910.GB18440@willie-the-truck> References: <20191108154838.21487-1-will@kernel.org> <20191108155503.GB15731@pendragon.ideasonboard.com> <20191216121651.GA12947@willie-the-truck> <20191218114137.GA15505@willie-the-truck> <20191218122324.GB17086@kroah.com> <20191218165153.GC17876@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218165153.GC17876@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2019 at 06:51:53PM +0200, Laurent Pinchart wrote: > On Wed, Dec 18, 2019 at 01:46:00PM +0100, Andrey Konovalov wrote: > > On Wed, Dec 18, 2019 at 1:23 PM Greg Kroah-Hartman wrote: > > > On Wed, Dec 18, 2019 at 11:41:38AM +0000, Will Deacon wrote: > > >> On Mon, Dec 16, 2019 at 02:17:52PM +0100, Andrey Konovalov wrote: > > >>> On Mon, Dec 16, 2019 at 1:16 PM Will Deacon wrote: > > >>>> On Fri, Nov 08, 2019 at 05:55:03PM +0200, Laurent Pinchart wrote: > > >>>>> Thank you for the patch. > > >>>>> > > >>>>> I'm sorry for the delay, and will have to ask you to be a bit more > > >>>>> patient I'm afraid. I will leave tomorrow for a week without computer > > >>>>> access and will only be able to go through my backlog when I will be > > >>>>> back on the 17th. > > >>>> > > >>>> Gentle reminder on this, now you've been back a month ;) > > >>> > > >>> I think we now have a reproducer for this issue that syzbot just reported: > > >>> > > >>> https://syzkaller.appspot.com/bug?extid=0a5c96772a9b26f2a876 > > >>> > > >>> You can try you patch on it :) > > >> > > >> Oh wow, I *really* like the raw USB gadget thingy you have to reproduce > > >> these! I also really like that this patch fixes the issue. Logs below. > > > > Thanks! An easier way to test the patch would be to issue a syz test > > command, but I'm glad you managed to set up raw gadget manually and it > > worked for you. > > > > > > > > Ok, that's a good poke for me to go review that raw gadget code to see > > > if it can be merged upstream :) > > > > Looking forward to it! =) > > Reviewed-by: Laurent Pinchart > > and merged in my tree. I'm so sorry for the way too long delay. Thanks, Laurent. Will