From: Ionela Voinescu <ionela.voinescu@arm.com> To: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com, dietmar.eggemann@arm.com, ionela.voinescu@arm.com Cc: peterz@infradead.org, mingo@redhat.com, ggherdovich@suse.cz, vincent.guittot@linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Steve Capper <steve.capper@arm.com> Subject: [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0 Date: Wed, 18 Dec 2019 18:26:03 +0000 [thread overview] Message-ID: <20191218182607.21607-3-ionela.voinescu@arm.com> (raw) In-Reply-To: <20191218182607.21607-1-ionela.voinescu@arm.com> The activity monitors extension is an optional extension introduced by the ARMv8.4 CPU architecture. In order to access the activity monitors counters safely, if desired, the kernel should detect the presence of the extension through the feature register, and mediate the access. Therefore, disable direct accesses to activity monitors counters from EL0 (userspace) and trap them to EL1 (kernel). Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Steve Capper <steve.capper@arm.com> --- arch/arm64/include/asm/assembler.h | 10 ++++++++++ arch/arm64/mm/proc.S | 3 +++ 2 files changed, 13 insertions(+) diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h index 2cc0dd8bd9f7..83bb499e8916 100644 --- a/arch/arm64/include/asm/assembler.h +++ b/arch/arm64/include/asm/assembler.h @@ -443,6 +443,16 @@ USER(\label, ic ivau, \tmp2) // invalidate I line PoU 9000: .endm +/* + * reset_amuserenr_el0 - reset AMUSERENR_EL0 if AMUv1 present + */ + .macro reset_amuserenr_el0, tmpreg + mrs \tmpreg, id_aa64pfr0_el1 // Check ID_AA64PFR0_EL1 + ubfx \tmpreg, \tmpreg, #ID_AA64PFR0_AMU_SHIFT, #4 + cbz \tmpreg, 9000f // Skip if no AMU present + msr_s SYS_AMUSERENR_EL0, xzr // Disable AMU access from EL0 +9000: + .endm /* * copy_page - copy src to dest using temp registers t1-t8 */ diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S index a1e0592d1fbc..d8aae1152c08 100644 --- a/arch/arm64/mm/proc.S +++ b/arch/arm64/mm/proc.S @@ -124,6 +124,7 @@ alternative_endif ubfx x11, x11, #1, #1 msr oslar_el1, x11 reset_pmuserenr_el0 x0 // Disable PMU access from EL0 + reset_amuserenr_el0 x0 // Disable AMU access from EL0 alternative_if ARM64_HAS_RAS_EXTN msr_s SYS_DISR_EL1, xzr @@ -415,6 +416,8 @@ ENTRY(__cpu_setup) isb // Unmask debug exceptions now, enable_dbg // since this is per-cpu reset_pmuserenr_el0 x0 // Disable PMU access from EL0 + reset_amuserenr_el0 x0 // Disable AMU access from EL0 + /* * Memory region attributes for LPAE: * -- 2.17.1
next prev parent reply other threads:[~2019-12-18 18:27 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-18 18:26 [PATCH v2 0/6] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 1/6] arm64: add support for the AMU extension v1 Ionela Voinescu 2020-01-23 17:04 ` Valentin Schneider 2020-01-23 18:32 ` Ionela Voinescu 2020-01-24 12:00 ` Valentin Schneider 2020-01-28 11:00 ` Ionela Voinescu 2020-01-28 16:34 ` Suzuki Kuruppassery Poulose 2020-01-29 16:42 ` Ionela Voinescu 2019-12-18 18:26 ` Ionela Voinescu [this message] 2020-01-23 17:04 ` [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0 Valentin Schneider 2020-01-23 17:34 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 3/6] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu 2020-01-27 15:33 ` Valentin Schneider 2020-01-28 15:48 ` Ionela Voinescu 2020-01-28 17:26 ` Suzuki Kuruppassery Poulose 2020-01-28 17:37 ` Valentin Schneider 2020-01-28 17:52 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 4/6] Documentation: arm64: document support for the AMU extension Ionela Voinescu 2020-01-27 16:47 ` Valentin Schneider 2020-01-28 16:53 ` Ionela Voinescu 2020-01-28 18:36 ` Valentin Schneider 2020-01-30 15:04 ` Suzuki Kuruppassery Poulose 2020-01-30 16:45 ` Ionela Voinescu 2020-01-30 18:26 ` Suzuki K Poulose 2020-01-31 9:54 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 5/6] TEMP: sched: add interface for counter-based frequency invariance Ionela Voinescu 2020-01-29 19:37 ` Peter Zijlstra 2020-01-30 15:33 ` Ionela Voinescu 2019-12-18 18:26 ` [PATCH v2 6/6] arm64: use activity monitors for " Ionela Voinescu 2020-01-23 11:49 ` Lukasz Luba 2020-01-23 17:07 ` Ionela Voinescu 2020-01-24 1:19 ` Lukasz Luba 2020-01-24 13:12 ` Ionela Voinescu 2020-01-24 15:17 ` Lukasz Luba 2020-01-28 17:36 ` Ionela Voinescu 2020-01-29 17:13 ` Valentin Schneider 2020-01-29 17:52 ` Ionela Voinescu 2020-01-29 23:39 ` Valentin Schneider 2020-01-30 15:49 ` Ionela Voinescu 2020-01-30 16:11 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191218182607.21607-3-ionela.voinescu@arm.com \ --to=ionela.voinescu@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dietmar.eggemann@arm.com \ --cc=ggherdovich@suse.cz \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=steve.capper@arm.com \ --cc=sudeep.holla@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=will@kernel.org \ --subject='Re: [PATCH v2 2/6] arm64: trap to EL1 accesses to AMU counters from EL0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).