From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472F2C2D0CD for ; Wed, 18 Dec 2019 19:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CB0121D7D for ; Wed, 18 Dec 2019 19:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HHNAemO2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbfLRTeo (ORCPT ); Wed, 18 Dec 2019 14:34:44 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53344 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727417AbfLRTeo (ORCPT ); Wed, 18 Dec 2019 14:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=F0qw+ZgAxUoSNUdtsCy/4y9ChBD5n/nHwz3C1MaWdgs=; b=HHNAemO2hQMNhgUhEnLcMkVsR iSxylsO6FhuzfM+X/t9mAWu3giItRNswznlmDgzqRYiN+xmGhY3vq9TxT4Ht8xNDIAYMVcjQzup8+ 0RJ2E+mYGLRezrOlBUNuYHxJ+wh5Oeev0LT4/vyTlWSkJZ1MJOMrDRdiAhDbLPV7xoF8rsmqjic7s Vw+FLSPx+1wgmWM24nDkNJzGJw9xkE+4L+iy1uu4eVVY8G2RnvuWuNlre++qoN4bXrFvekH9YvGFm Z8VRyHEhCU69fJjtNwWt862jCce2fhGupp/sOl/O/CodhTWkju1VuOkZJSWsStwbfZ/o3kborZ7iJ Yv5Pb5HRg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihf5b-0002JF-32; Wed, 18 Dec 2019 19:34:31 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 20D5D980E35; Wed, 18 Dec 2019 20:34:29 +0100 (CET) Date: Wed, 18 Dec 2019 20:34:29 +0100 From: Peter Zijlstra To: Giovanni Gherdovich Cc: Ionela Voinescu , Srinivas Pandruvada , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Len Brown , "Rafael J . Wysocki" , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mel Gorman , Matt Fleming , Viresh Kumar , Juri Lelli , Paul Turner , Vincent Guittot , Quentin Perret , Dietmar Eggemann , Doug Smythies Subject: Re: [PATCH v4 1/6] x86,sched: Add support for frequency invariance Message-ID: <20191218193429.GH11457@worktop.programming.kicks-ass.net> References: <20191113124654.18122-1-ggherdovich@suse.cz> <20191113124654.18122-2-ggherdovich@suse.cz> <20191202162232.GA9777@arm.com> <4d1b776d8e797224e92952a4d590a625@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d1b776d8e797224e92952a4d590a625@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 06, 2019 at 12:57:46PM +0100, Giovanni Gherdovich wrote: > > On Wednesday 13 Nov 2019 at 13:46:49 (+0100), Giovanni Gherdovich wrote: > > I see above that you enable the static key (and therefore frequency > > invariance before setting the max frequency ratio (if possible) and > > before you initialise the counter references. Is there any reason for > > doing this? > This is a fair point; mine was a deliberate choice but you're the second > person making this remark (Peter Zijlstra also suggested I find the max > frequency before I set the static key), so it appears this design is > unpopular > enough to warrant a change in v5. You actually 'fix' this in the next patch. I thought it was a patch management 'fail' that it didn't end up in this patch.