From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB48CC43603 for ; Fri, 20 Dec 2019 01:34:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5F9B206CB for ; Fri, 20 Dec 2019 01:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727190AbfLTBee (ORCPT ); Thu, 19 Dec 2019 20:34:34 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:45020 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfLTBed (ORCPT ); Thu, 19 Dec 2019 20:34:33 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 133921540B9A3; Thu, 19 Dec 2019 17:34:33 -0800 (PST) Date: Thu, 19 Dec 2019 17:34:32 -0800 (PST) Message-Id: <20191219.173432.1907178642147983703.davem@davemloft.net> To: pakki001@umn.edu Cc: kjlu@umn.edu, tglx@linutronix.de, elfring@users.sourceforge.net, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register From: David Miller In-Reply-To: <20191217210620.29775-1-pakki001@umn.edu> References: <20191217210620.29775-1-pakki001@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 19 Dec 2019 17:34:33 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki Date: Tue, 17 Dec 2019 15:06:19 -0600 > In hdlcdrv_register, failure to register the driver causes a crash. > The three callers of hdlcdrv_register all pass valid pointers and > do not fail. The patch eliminates the unnecessary BUG_ON assertion. > > Signed-off-by: Aditya Pakki Applied to net-next.