linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Khouloud Touil <ktouil@baylibre.com>
To: bgolaszewski@baylibre.com, robh+dt@kernel.org,
	mark.rutland@arm.com, srinivas.kandagatla@linaro.org,
	baylibre-upstreaming@groups.io
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-i2c@vger.kernel.org, linus.walleij@linaro.org,
	Khouloud Touil <ktouil@baylibre.com>
Subject: [PATCH v3 0/4] at24: move write-protect pin handling to nvmem core
Date: Thu, 19 Dec 2019 12:51:37 +0100	[thread overview]
Message-ID: <20191219115141.24653-1-ktouil@baylibre.com> (raw)

The write-protect pin handling looks like a standard property that
could benefit other users if available in the core nvmem framework.
    
Instead of modifying all the drivers to check this pin, make the
nvmem subsystem check if the write-protect GPIO being passed
through the nvmem_config or defined in the device tree and pull it
low whenever writing to the memory.

This patchset:

- adds support for the write-protect pin split into two parts.
The first patch modifies modifies the relevant binding document,
while the second modifies the nvmem code to pull the write-protect
GPIO low (if present) during write operations.

- removes support for the write-protect pin split into two parts.
The first patch modifies the relevant binding document to remove
the wp-gpio, while the second removes the relevant code in the
at24 driver.

Changes since v1:
-Add an explenation on how the wp-gpios works
-keep reference to the wp-gpios in the at24 binding

Changes since v2:
-Use the flag GPIO_ACTIVE_HIGH instead of 0


Khouloud Touil (4):
  dt-bindings: nvmem: new optional property write-protect-gpios
  nvmem: add support for the write-protect pin
  dt-bindings: at24: remove the optional property write-protect-gpios
  eeprom: at24: remove the write-protect pin support

 .../devicetree/bindings/eeprom/at24.yaml      |  6 +-----
 .../devicetree/bindings/nvmem/nvmem.yaml      | 11 +++++++++++
 drivers/misc/eeprom/at24.c                    |  9 ---------
 drivers/nvmem/core.c                          | 19 +++++++++++++++++--
 drivers/nvmem/nvmem.h                         |  2 ++
 include/linux/nvmem-provider.h                |  3 +++
 6 files changed, 34 insertions(+), 16 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-12-19 11:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 11:51 Khouloud Touil [this message]
2019-12-19 11:51 ` [PATCH v3 1/4] dt-bindings: nvmem: new optional property write-protect-gpios Khouloud Touil
2020-01-03 23:40   ` Rob Herring
2019-12-19 11:51 ` [PATCH v3 2/4] nvmem: add support for the write-protect pin Khouloud Touil
2019-12-19 11:51 ` [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios Khouloud Touil
2020-01-03 23:44   ` Rob Herring
2019-12-19 11:51 ` [PATCH v3 4/4] eeprom: at24: remove the write-protect pin support Khouloud Touil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191219115141.24653-1-ktouil@baylibre.com \
    --to=ktouil@baylibre.com \
    --cc=baylibre-upstreaming@groups.io \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).