From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: fix exclusive_console replaying
Date: Thu, 19 Dec 2019 15:22:35 +0100 [thread overview]
Message-ID: <20191219142235.4zpabzlyhav6d3cd@pathway.suse.cz> (raw)
In-Reply-To: <20191219115322.31160-1-john.ogness@linutronix.de>
On Thu 2019-12-19 12:59:22, John Ogness wrote:
> Commit f92b070f2dc8 ("printk: Do not miss new messages when replaying
> the log") introduced a new variable @exclusive_console_stop_seq to
> store when an exclusive console should stop printing. It should be
> set to the @console_seq value at registration. However, @console_seq
> is previously set to @syslog_seq so that the exclusive console knows
> where to begin. This results in the exclusive console immediately
> reactivating all the other consoles and thus repeating the messages
> for those consoles.
>
> Set @console_seq after @exclusive_console_stop_seq has stored the
> current @console_seq value.
>
> Fixes: f92b070f2dc8 ("printk: Do not miss new messages when replaying the log")
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Grr, it was an ugly mistake. I am surprised that it has stayed there
for more then one year without noticing. Thanks a lot for fixing.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2019-12-19 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 11:53 [PATCH] printk: fix exclusive_console replaying John Ogness
2019-12-19 14:22 ` Petr Mladek [this message]
2019-12-23 0:18 ` Sergey Senozhatsky
2020-01-02 15:35 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219142235.4zpabzlyhav6d3cd@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).