From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] Tegra GPIO: Minor code clean up
Date: Thu, 19 Dec 2019 15:53:41 +0100 [thread overview]
Message-ID: <20191219145341.GL1440537@ulmo> (raw)
In-Reply-To: <20191215183047.9414-1-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
On Sun, Dec 15, 2019 at 09:30:44PM +0300, Dmitry Osipenko wrote:
> Hello,
>
> I was investigating why CPU hangs during of GPIO driver suspend and in
> the end it turned out that it is a Broadcom WiFi driver problem because
> it keeps OOB wake-interrupt enabled while WLAN interface is DOWN and this
> may cause a bit weird CPU hang on writing to INT_ENB register during of
> GPIO driver suspend. Meanwhile I also noticed that a few things could be
> improved in the driver, that's what this small series addresses.
>
> Dmitry Osipenko (3):
> gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors
> gpio: tegra: Properly handle irq_set_irq_wake() error
> gpio: tegra: Use NOIRQ phase for suspend/resume
>
> drivers/gpio/gpio-tegra.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
Patches look good:
Reviewed-by: Thierry Reding <treding@nvidia.com>
I also applied this series on top of v5.5-rc1 and ran it through our
test system:
Test results:
13 builds: 13 pass, 0 fail
22 boots: 22 pass, 0 fail
34 tests: 34 pass, 0 fail
Linux version: 5.5.0-rc1-g3d0b4fced39e
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
All tests passing, so:
Tested-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-19 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 18:30 [PATCH v1 0/3] Tegra GPIO: Minor code clean up Dmitry Osipenko
2019-12-15 18:30 ` [PATCH v1 1/3] gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors Dmitry Osipenko
2019-12-19 11:01 ` Bartosz Golaszewski
2019-12-19 15:25 ` Dmitry Osipenko
2019-12-19 15:57 ` Ben Dooks
2019-12-19 16:34 ` Dmitry Osipenko
2019-12-15 18:30 ` [PATCH v1 2/3] gpio: tegra: Properly handle irq_set_irq_wake() error Dmitry Osipenko
2019-12-15 18:30 ` [PATCH v1 3/3] gpio: tegra: Use NOIRQ phase for suspend/resume Dmitry Osipenko
2019-12-16 14:45 ` [PATCH v1 0/3] Tegra GPIO: Minor code clean up Dmitry Osipenko
2019-12-19 14:53 ` Thierry Reding [this message]
2019-12-19 15:26 ` Dmitry Osipenko
2020-01-06 22:59 ` Linus Walleij
2020-01-07 8:25 ` Bartosz Golaszewski
2020-01-07 9:29 ` Linus Walleij
2020-01-07 9:31 ` Bartosz Golaszewski
2020-01-07 12:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219145341.GL1440537@ulmo \
--to=thierry.reding@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).