From: Vinod Koul <vkoul@kernel.org>
To: cang@codeaurora.org
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] phy: qcom-qmp: Use register defines
Date: Fri, 20 Dec 2019 09:52:30 +0530 [thread overview]
Message-ID: <20191220042230.GD2536@vkoul-mobl> (raw)
In-Reply-To: <9e69d0b803cdbfe69d6edb62b8aa9b24@codeaurora.org>
On 20-12-19, 08:44, cang@codeaurora.org wrote:
> On 2019-12-19 23:04, Vinod Koul wrote:
> > We already define register offsets so use them in register layout.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
> > b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > index c2e800a3825a..06f971ca518e 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > @@ -166,8 +166,8 @@ static const unsigned int
> > sdm845_ufsphy_regs_layout[] = {
> > };
> >
> > static const unsigned int sm8150_ufsphy_regs_layout[] = {
> > - [QPHY_START_CTRL] = 0x00,
> > - [QPHY_PCS_READY_STATUS] = 0x180,
> > + [QPHY_START_CTRL] = QPHY_V4_PHY_START,
> > + [QPHY_SW_RESET] = QPHY_V4_SW_RESET,
> > };
> >
> > static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {
>
> Why is the QPHY_PCS_READY_STATUS removed here? Then what "status" are we
> polling here for UFS PHY?
>
> <snip>
> if (cfg->type == PHY_TYPE_UFS) {
> status = pcs + cfg->regs[QPHY_PCS_READY_STATUS];
> mask = PCS_READY;
> ready = PCS_READY;
> } else {
> <snip>
Good catch Can, I dont think I intended it that way. Will fix it up!
Thanks
--
~Vinod
next prev parent reply other threads:[~2019-12-20 4:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:04 [PATCH 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-19 15:04 ` [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Vinod Koul
2019-12-19 15:29 ` Jeffrey Hugo
2019-12-19 15:40 ` Vinod Koul
2019-12-20 2:08 ` Bjorn Andersson
2019-12-20 4:21 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 2/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-19 15:30 ` Jeffrey Hugo
2019-12-20 0:44 ` cang
2019-12-20 4:22 ` Vinod Koul [this message]
2019-12-19 15:04 ` [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 0:22 ` cang
2019-12-20 0:49 ` cang
2019-12-20 4:24 ` Vinod Koul
2019-12-20 6:00 ` Can Guo
2019-12-20 7:10 ` Vinod Koul
2019-12-20 7:41 ` Can Guo
2019-12-20 7:53 ` Vinod Koul
2019-12-23 9:00 ` Manu Gautam
2019-12-23 9:02 ` Manu Gautam
2019-12-19 15:04 ` [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 1:30 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220042230.GD2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).