From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 587F8C2D0C0 for ; Fri, 20 Dec 2019 09:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 230F824685 for ; Fri, 20 Dec 2019 09:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576835881; bh=GmxrDdeOg4cCheaZlgE6D51yTf+SUe1HRp8l+b4QsCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=UslCIoHY9NAJ1wwTp+IfGPdHZRr+VTuxqnclfKhtJaG3r+isFi7C0UsBgKKMYWJse u/ND0+wR0jIAcHrjyTSbAOqzPavpVbHPfTZJyvvOsiRblfdde2pVUI5WJhmH1jh7ni EUAHVihjx8uU808+NvfD4bfWOkXvM6IIcIDhn4jY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbfLTJ6A (ORCPT ); Fri, 20 Dec 2019 04:58:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:46898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727176AbfLTJ6A (ORCPT ); Fri, 20 Dec 2019 04:58:00 -0500 Received: from localhost (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3375206EC; Fri, 20 Dec 2019 09:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576835879; bh=GmxrDdeOg4cCheaZlgE6D51yTf+SUe1HRp8l+b4QsCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sVCj5Lr63v5zXDgurOvuFgpKc3hYSbcFTPJuJVlgenwasTnIGAkZ3oebH8v4nHT6E Rb8qynWq1Far66Y2GlG00m1a6kcayL4jf+YdB3deHtKUEetjvQPuSNFAmStdmNWf8m mN7j2DGGxHgk8C9xSSb0i/voEWp4ExsVWy7Vg2cE= Date: Fri, 20 Dec 2019 15:27:55 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com, j-keerthy@ti.com, vigneshr@ti.com Subject: Re: [PATCH v7 05/12] dmaengine: Add support for reporting DMA cached data amount Message-ID: <20191220095755.GN2536@vkoul-mobl> References: <20191209094332.4047-1-peter.ujfalusi@ti.com> <20191209094332.4047-6-peter.ujfalusi@ti.com> <20191220083713.GL2536@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-12-19, 10:49, Peter Ujfalusi wrote: > >> +static inline void dma_set_in_flight_bytes(struct dma_tx_state *state, > >> + u32 in_flight_bytes) > >> +{ > >> + if (state) > >> + state->in_flight_bytes = in_flight_bytes; > >> +} > > > > This would be used by dmaengine drivers right, so lets move it to drivers/dma/dmaengine.h > > > > lets not expose this to users :) > > I have put it where the dma_set_residue() was. > I can add a patch first to move dma_set_residue() then add not sure I follow, but dma_set_residue() in already in drivers/dma/dmaengine.h > dma_set_in_flight_bytes() there as well? -- ~Vinod