From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4772C43603 for ; Fri, 20 Dec 2019 14:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80AF0206CB for ; Fri, 20 Dec 2019 14:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576852427; bh=wkJAdtkBXdnXu9aJYtGZe9L7P79h8OzAjQykNDwnR8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=G019D4xokt3PNJbm9tiSGZL/XNwY/eZC0g1Kcys2ZZGV2P3WbIDfJDnzTqQRAVUvL qMKd8xxvP8EDRvwVKry1xfDjRynvpvsNqt38ehJl0V+RXkdDZzSTl1gdMhNIUuJX91 F4udHQAm1ghiRjR72dmrc+1q66Y2e0+GJt7RdJao= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728263AbfLTOdq (ORCPT ); Fri, 20 Dec 2019 09:33:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:34304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbfLTOah (ORCPT ); Fri, 20 Dec 2019 09:30:37 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D52924689; Fri, 20 Dec 2019 14:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576852236; bh=wkJAdtkBXdnXu9aJYtGZe9L7P79h8OzAjQykNDwnR8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fvV72O5uH60SYxsRPw0oX0FHw1sniAi1uX4lOH9N3rNvQSYbnQpaHmBvPFwnCdH/X kBdY/i46RwyeMVUuQ8jodc2nqcdg8Xg0qEziE5nfe2KwOlmbAPCapblCzMxCUfw9eR +xgXwMwkHdAN3vQKG+7qNc1kB9imgGfa9Tk0lRFY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Roman Bolshakov , Himanshu Madhani , Quinn Tran , Hannes Reinecke , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 30/52] scsi: qla2xxx: Don't defer relogin unconditonally Date: Fri, 20 Dec 2019 09:29:32 -0500 Message-Id: <20191220142954.9500-30-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191220142954.9500-1-sashal@kernel.org> References: <20191220142954.9500-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roman Bolshakov [ Upstream commit dabc5ec915f3a2c657ecfb529cd3d4ec303a4412 ] qla2x00_configure_local_loop sets RELOGIN_NEEDED bit and calls qla24xx_fcport_handle_login to perform the login. This bit triggers a wake up of DPC later after a successful login. The deferred call is not needed if login succeeds, and it's set in qla24xx_fcport_handle_login in case of errors, hence it should be safe to drop. Link: https://lore.kernel.org/r/20191125165702.1013-12-r.bolshakov@yadro.com Acked-by: Himanshu Madhani Acked-by: Quinn Tran Reviewed-by: Hannes Reinecke Tested-by: Hannes Reinecke Signed-off-by: Roman Bolshakov Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 7364f3b62b9d9..1c3a5fcbd3153 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -5043,7 +5043,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha) memcpy(&ha->plogi_els_payld.data, (void *)ha->init_cb, sizeof(ha->plogi_els_payld.data)); - set_bit(RELOGIN_NEEDED, &vha->dpc_flags); } else { ql_dbg(ql_dbg_init, vha, 0x00d1, "PLOGI ELS param read fail.\n"); -- 2.20.1