From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B7FC3F68F for ; Sat, 21 Dec 2019 20:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91FCA206B7 for ; Sat, 21 Dec 2019 20:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbfLUUWA (ORCPT ); Sat, 21 Dec 2019 15:22:00 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:48428 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbfLUUWA (ORCPT ); Sat, 21 Dec 2019 15:22:00 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9E47B1C24A9; Sat, 21 Dec 2019 21:21:57 +0100 (CET) Date: Sat, 21 Dec 2019 21:21:56 +0100 From: Pavel Machek To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: linux-realtek-soc@lists.infradead.org, linux-leds@vger.kernel.org, Jacek Anaszewski , Dan Murphy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [RFC 14/25] arm64: dts: realtek: rtd1295-xnano-x5: Add regular LEDs to FD628 Message-ID: <20191221202156.GL32732@amd> References: <20191212033952.5967-1-afaerber@suse.de> <20191212033952.5967-15-afaerber@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rfwNdt5cNUUjB/69" Content-Disposition: inline In-Reply-To: <20191212033952.5967-15-afaerber@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rfwNdt5cNUUjB/69 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Add child nodes for individual LED indicators plus the half-second colon. >=20 > Signed-off-by: Andreas F=E4rber > --- > + apps@1,4 { > + reg =3D <1 4>; > + color =3D ; > + function =3D LED_FUNCTION_INDICATOR; > + function-enumerator =3D <1>; > + }; > + > + setup@2,4 { > + reg =3D <2 4>; > + color =3D ; > + function =3D LED_FUNCTION_INDICATOR; > + function-enumerator =3D <2>; > + }; having 10 "indicator" leds is not going to be exactly useful. So, what does the display look like? "apps", "setup", "usb", "card", =2E.. texts? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --rfwNdt5cNUUjB/69 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3+fuQACgkQMOfwapXb+vKpLACfQv6vWFQeNIi5z/L8L8LVHFOD K8EAoJZ1a/I813U8L01scB3b7YB0aRsq =AN0b -----END PGP SIGNATURE----- --rfwNdt5cNUUjB/69--