From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA11C2D0D4 for ; Mon, 23 Dec 2019 07:54:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4D0F20709 for ; Mon, 23 Dec 2019 07:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577087697; bh=2yh3uiTddvCjS7EKZmDMOjEsrl7nNSl2DDHRdpfkucM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KTvta5ZQpHCNvPxs3KOdRSTpNRJYXhyhq1AzG5NYgmwbwwOf796w9LhHpY3OfzgJR dmKM7tGnfrCfN9FIlKNvUaBPmKDWWDErOXVzagmiu7uVpBrPVBqbvKgNBqOfRYGR8U IAzuiAaKUOP30gzc+I1BnEZwlhhWv1bcjBfUfXVs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbfLWHy4 (ORCPT ); Mon, 23 Dec 2019 02:54:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:58056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfLWHyz (ORCPT ); Mon, 23 Dec 2019 02:54:55 -0500 Received: from localhost (unknown [223.226.34.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9ECD0206B7; Mon, 23 Dec 2019 07:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577087695; bh=2yh3uiTddvCjS7EKZmDMOjEsrl7nNSl2DDHRdpfkucM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VUOyLSLHEKQDCiquoEAkVHUJzNOQ1BRWseTRI2muai1LY0mcdWKIlB4yiEEVFT1y0 lxyEIc6wq+zY8iiNawNo1RTevyvujkMuWRVRugxr+OSL6g2/v+jiI81N8HtYzoKXWv IYbhaEvFmuMwhd+p5UDGX9XTOmPPnpqmCeUdP/Sk= Date: Mon, 23 Dec 2019 13:24:51 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: "Ardelean, Alexandru" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dmaengine: virt-dma: Fix access after free in vcna_complete() Message-ID: <20191223075451.GE2536@vkoul-mobl> References: <20191220131100.21804-1-peter.ujfalusi@ti.com> <0303ceda023121d9048d2508e28c0306b1871561.camel@analog.com> <486093bc-b1bf-1727-0402-f07606fffd1e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <486093bc-b1bf-1727-0402-f07606fffd1e@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-12-19, 16:50, Peter Ujfalusi wrote: > > > On 20/12/2019 16.01, Ardelean, Alexandru wrote: > > On Fri, 2019-12-20 at 15:11 +0200, Peter Ujfalusi wrote: > >> [External] > >> > >> vchan_vdesc_fini() is freeing up 'vd' so the access to vd->tx_result is > >> via already freed up memory. > >> > >> Move the vchan_vdesc_fini() after invoking the callback to avoid this. > >> > > > > Apologies for seeing this too late: typo in title vcna_complete() -> > > vchan_complete() > > Yep, I also noticed after sending it, I hope Vinod is kind enough and > fix it up when applying ;) In case it wasnt clear, yeah trivial changes while applying are no hassle :) -- ~Vinod